Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7304 - Update tab order for CSV import dialog to match screen order #7315

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

mrm48
Copy link
Contributor

@mrm48 mrm48 commented Jan 20, 2022

CSV import dialog placed some elements in the middle of the screen towards the end of the tab order

Screenshots

image

Testing strategy

  1. Click Database -> Import -> CSV in the toolbar
  2. Create a test database with a blank CSV file
  3. When specifying which password database fields correspond to which fields in the CSV file, press tab to navigate through the field types.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #7315 (a1829ea) into develop (56a1b46) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7315      +/-   ##
===========================================
- Coverage    64.33%   64.30%   -0.03%     
===========================================
  Files          337      337              
  Lines        42448    42448              
===========================================
- Hits         27305    27294      -11     
- Misses       15143    15154      +11     
Impacted Files Coverage Δ
...rc/fdosecrets/widgets/SettingsWidgetFdoSecrets.cpp 58.92% <0.00%> (-3.24%) ⬇️
src/fdosecrets/dbus/DBusMgr.cpp 52.20% <0.00%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a1b46...a1829ea. Read the comment docs.

@droidmonkey droidmonkey merged commit b29e8fb into keepassxreboot:develop Jan 29, 2022
@droidmonkey droidmonkey added this to the v2.7.0 milestone Feb 26, 2022
@droidmonkey droidmonkey linked an issue Feb 26, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import CSV File dialog tab order
3 participants