KeeShare: Remove checking signed container and QuaZip #7223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
pr: refactoring
droidmonkey
force-pushed
the
refactor/keeshare-part1
branch
5 times, most recently
from
5a00683 to
77a8230
Compare
phoerious
approved these changes
Dec 14, 2021
|
Need to fix the TestSharing build to include the core library. |
* Remove QuaZip dependency in favor of minizip * Remove signature checks, but maintain signatures for backwards compatibility * Remove UI components related to certificates except for personal certificate for backwards compatibility * Default to unsigned containers (*.kdbx)
|
I ended up reverting the BinaryStream file move and used a QDataStream to write the ssh-rsa key signature file. |
droidmonkey
force-pushed
the
refactor/keeshare-part1
branch
from
77a8230 to
dc39b31
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7223 +/- ##
===========================================
+ Coverage 64.22% 64.57% +0.35%
===========================================
Files 336 335 -1
Lines 42377 42032 -345
===========================================
- Hits 27214 27138 -76
+ Misses 15163 14894 -269
Continue to review full report at Codecov.
|
yan12125
pushed a commit
to archlinuxcn/repo
that referenced
this pull request
Dec 15, 2021
In keepassxreboot/keepassxc#7223, quazip is replaced by minizip, and the option -DWITH_XC_KEESHARE_SECURE is gone.
yan12125
pushed a commit
to archlinuxcn/repo
that referenced
this pull request
Mar 2, 2022
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
This is the original KeeShare settings in 2.6.6 (showing trusted keys generated in 2.7.0 at the bottom):
This is the new settings view in 2.7.0:
Testing strategy
Tested KeeShare between 2.7.0 and 2.6.6, worked perfectly. Signatures are still recognized and validated in 2.6.6 so backwards compatibility is maintained. In 2.7.0 we no longer care about verifying the signature.
Type of change