Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept kdbx:// urls in Edit Entry view #7221

Conversation

varjolintu
Copy link
Member

Fix displying URLs starting with kdbx:// as invalid.

Fixes #7220.

Testing strategy

Manually.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@varjolintu varjolintu added the bug label Dec 12, 2021
@varjolintu varjolintu added this to the v2.7.0 milestone Dec 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.33%. Comparing base (cd642e7) to head (0ec9503).
Report is 541 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7221      +/-   ##
===========================================
+ Coverage    64.30%   64.33%   +0.03%     
===========================================
  Files          337      337              
  Lines        42447    42448       +1     
===========================================
+ Hits         27295    27307      +12     
+ Misses       15152    15141      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

src/core/Tools.cpp Show resolved Hide resolved
@droidmonkey droidmonkey force-pushed the fix/accept_kdbx_url_in_edit_entry_view branch from 68aeed4 to 0ec9503 Compare December 30, 2021 12:43
@droidmonkey droidmonkey merged commit 7efaca6 into keepassxreboot:develop Dec 30, 2021
@varjolintu varjolintu deleted the fix/accept_kdbx_url_in_edit_entry_view branch December 30, 2021 14:05
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLs starting with a slash (e.g. kdbx:///path/to/db.kdbx) displayed as invalid
4 participants