Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Browser statistics #7197

Merged

Conversation

varjolintu
Copy link
Member

@varjolintu varjolintu commented Dec 4, 2021

Adds support for Browser Statistics in Database Reports.

Features:

  • Lists all URLs in the entry
  • Separate column for allowed and denied URLs
  • Possibility to exclude expired entries from the list
  • Possibility to show only entries with URL(s) set
  • Possibility to show only entries with Browser Integration related custom data set
  • Possibility to edit entries

Fixes #6847.

Screenshots

Screenshot 2021-11-28 at 17 52 21

Testing strategy

Manually.

Type of change

  • ✅ New feature (change that adds functionality)

@varjolintu varjolintu added this to the v2.7.0 milestone Dec 4, 2021
@varjolintu varjolintu marked this pull request as draft December 4, 2021 10:19
@varjolintu
Copy link
Member Author

I left the color palette changes to the commit if you think we should add some background colors for example entires without any URL etc.

@varjolintu varjolintu force-pushed the feature/browser_statistics branch from c09d3d7 to 5af77f8 Compare December 4, 2021 11:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2021

Codecov Report

Attention: Patch coverage is 14.13043% with 237 lines in your changes missing coverage. Please review.

Project coverage is 64.30%. Comparing base (15d1b2f) to head (13662a1).
Report is 542 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/reports/ReportsWidgetBrowserStatistics.cpp 8.66% 211 Missing ⚠️
src/core/Entry.cpp 0.00% 13 Missing ⚠️
src/gui/reports/ReportsPageBrowserStatistics.cpp 53.85% 6 Missing ⚠️
src/gui/reports/ReportsDialog.cpp 69.23% 4 Missing ⚠️
src/gui/styles/StateColorPalette.cpp 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7197      +/-   ##
===========================================
- Coverage    64.63%   64.30%   -0.33%     
===========================================
  Files          335      337       +2     
  Lines        42172    42447     +275     
===========================================
+ Hits         27257    27293      +36     
- Misses       14915    15154     +239     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@varjolintu
Copy link
Member Author

Still one bug left: after editing an entry, the list is not updated.

@varjolintu varjolintu force-pushed the feature/browser_statistics branch from 8fc20f4 to f6ebbf7 Compare December 7, 2021 20:27
@varjolintu varjolintu marked this pull request as ready for review December 7, 2021 20:58
@droidmonkey droidmonkey force-pushed the feature/browser_statistics branch from f6ebbf7 to 13662a1 Compare December 28, 2021 12:39
@droidmonkey
Copy link
Member

I tweaked the report to have the same column flow as the others. Also moved the general database stats to the top, not sure why that was ever at the bottom.

image

@varjolintu
Copy link
Member Author

@droidmonkey Thanks for the tweaks!

@droidmonkey droidmonkey merged commit cd642e7 into keepassxreboot:develop Dec 30, 2021
@varjolintu varjolintu deleted the feature/browser_statistics branch December 30, 2021 12:58
t-h-e pushed a commit to t-h-e/keepassxc that referenced this pull request Sep 8, 2022
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy way to see which entries are connected to browser
4 participants