Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Agent: Show correct error messages in main window #7166

Merged

Conversation

hifi
Copy link
Member

@hifi hifi commented Nov 24, 2021

Fixes #7152

The error checking code for main window agent operations were completely off and 100% useless, like the author of the code.

I said I'll disable the context menu but it looks a bit heavy to actually do all of the checks at that point. This fixes the error message, though.

Testing strategy

Adding and removing a key with attachment type selected but the attachment left empty.. Shouldn't require much more.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@hifi hifi added this to the v2.7.0 milestone Nov 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.13%. Comparing base (296cbf0) to head (4510799).
Report is 557 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/DatabaseWidget.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7166      +/-   ##
===========================================
+ Coverage    64.12%   64.13%   +0.02%     
===========================================
  Files          335      335              
  Lines        42284    42288       +4     
===========================================
+ Hits         27111    27121      +10     
+ Misses       15173    15167       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey
Copy link
Member

At least the author of the code can fix the problems when they are found. Estimating 45% usefulness 😄

@droidmonkey droidmonkey merged commit 2fb1c07 into keepassxreboot:develop Nov 25, 2021
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: SSH agent pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH key is not added to the agent with missing error message
4 participants