SSH Agent: Show correct error messages in main window #7166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7152
The error checking code for main window agent operations were completely off and 100% useless, like the author of the code.
I said I'll disable the context menu but it looks a bit heavy to actually do all of the checks at that point. This fixes the error message, though.
Testing strategy
Adding and removing a key with attachment type selected but the attachment left empty.. Shouldn't require much more.
Type of change