Auto-Type: Reimplement X11 keysym emulation #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression since 4d07507
If there's a system wide configuration through xorg.conf for a default keyboard layout and it's not updated by the WM/DE at startup the Xkb extension seems to be somewhat confused with XTEST and the layout somehow defaults to US ANSI. Reading the keyboard description and writing it back without changes works around this.
Flushing isn't enough and some keypresses might be lost.
hifi
force-pushed
the
fix/x11-keysym-emulation
branch
from
40bcc1e to
8ecd56d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7098 +/- ##
===========================================
+ Coverage 63.95% 63.96% +0.01%
===========================================
Files 330 330
Lines 41764 41764
===========================================
+ Hits 26708 26711 +3
+ Misses 15056 15053 -3
Continue to review full report at Codecov.
|
droidmonkey
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression since 4d07507
Testing strategy
Tried a few times, needs more testing.
Type of change