Colored passwords in the preview pane #7097
Conversation
Codecov ReportBase: 64.39% // Head: 64.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7097 +/- ##
===========================================
+ Coverage 64.39% 64.42% +0.03%
===========================================
Files 339 339
Lines 43990 43968 -22
===========================================
- Hits 28324 28322 -2
+ Misses 15666 15646 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Not really possible to resolve the conflict in demo.kdbx. You may keep or undo my changes, doesn't really matter, I didn't change anything significant. |
|
Didn't realise this was in draft state. Un-drafted so it can be reviewed and eventually merged. Any chance to get it into the upcoming 2.7? |
|
This will be looked at for 2.7.1 |
wolframroesler
force-pushed
the
feature/colour-passwds
branch
from
6030fbe to
246530f
Compare
|
Thanks @droidmonkey. Rebased it onto current develop and resolved the conflict in demo.kdbx so all should be good now. |
version 2.7.1 does not include this evolution, is it correct? |
|
Still open and unmerged |
|
I am really just not a fan of colored passwords at all. KeePassDX implemented it on Android and it looks terrible, immediately disabled. I am, however, in favor of a popup widget that separately shows the password in large text with color and maybe even the position numbers below the letters. This could also be a way to perform "pickchars" auto-type directly from this widget. Thoughts @wolframroesler @phoerious |
|
The pop-idea sounds good, but should go into a different issue. About the colours, some like them and some don't, the feedback I got when asking about it on Twitter (https://twitter.com/WolframRoesler/status/1452928493549981696) was mostly positive. Some people would definitely benefit from it (myself included) so the feature should be available IMHO, especially because there's a configuration option to turn it off; perhaps we could turn it off by default if it's too distracting for the majority of users. Strongbox has been having it for a long time. What feedback did you receive, @strongbox-mark? |
Yes, entirely positive for both the Large Text popup feature and the colorized passwords. Not a single complaint, all positive comments, but I can understand why some don't like it. :) BTW, on a completely separate topic, I can't respond to the other issue #863 as it's limited to collaborators - I meant to get in touch / reply to @varkolintu there, as this is something I'm considering adding support to Strongbox for (Credit Card fields or some kind of standardization for them). Was going to drop you guys a mail, but since we're here, can you add me as a collaborator there so that I can respond/chat, or is there a better place to do it? |
and on Stongbox I can't do without this feature. I'm looking forward to it on KeepassXC! |
|
@strongbox-mark unlocked the issue! Although that thread is super long, we could also start a new discussion thread about the api / implementation. I too am very interested in it, just a lot of gui work. I'll merge this feature in after another review of the code. A similar comment I have from the other colorized text one... it would be good to extract the code that actually creates the html so we can use it across multiple widgets (like the password generator) if we so desire. Although Qt annoyingly does not allow html in qlineedit. |
|
Nice one, thank you @droidmonkey - Yes, it's such a big feature it's daunting, I wonder if we can some how trim the scope down very heavily and go for some kind of simplified "Entry Type" system with a fairly fixed set of well-known or conventional fields doing the heavy lifting... Of course, GUI work on top will be arduous for all of us :/ |
Concerning the password colors, I also have only positive feedback, except yours. It allows users who manually copy elements to find their way around better. Of course, if you have suggestions to improve visibility by harmonizing colors between applications, I am open to proposals to update KeePassDX. |
|
I'd love to see this feature in KeePassXC. Is this being worked on/considered to be added soon? I took a look at the milestones for v2.7.2 and v2.8.0 and they don't contain this. After reading the conversation I get the impression that the work has been done and it just needs a review. |
|
Hi @mariuszdb, you're right, the implementation is finished (cf. the screenshots above) and ready to be reviewed and merged. |
droidmonkey
force-pushed
the
feature/colour-passwds
branch
from
246530f to
2abb634
Compare
|
Made a few changes to the code and actually found a bug in our theme switching as well! This also fixes password overflow UI by showing a horizontal scroll bar on long passwords.
|
droidmonkey
added
the
pr: backport pending
droidmonkey
force-pushed
the
feature/colour-passwds
branch
3 times, most recently
from
ecccd55 to
ef49c7f
Compare
Closes keepassxreboot#4099 * Fixed bug in Application that did not set the dark theme flag when the theme was changed from dark to light.
droidmonkey
force-pushed
the
feature/colour-passwds
branch
from
ef49c7f to
4faed7a
Compare
droidmonkey
added
pr: backported
|
This is a great improvement that I just discovered, thanks for the merge! I would like to request different colors however. Green and blue can not always be well distinguished. Take this screenshot for example. At 1:1 zoom I can not easily tell apart blue from green. Both sort-of look black-ish (move your head back from the screen a bit if it's still easy for you :) )
Thanks! |
In the entry preview pane, the password is now displayed with in multiple colours (digits in blue, upper-case letters in red, etc). The idea and the color scheme are taken from the iOS app "Strongbox".
A checkbox was added to section "General -> User Interface" of the settings dialog to turn color display off.
Fixes #4099
Screenshots
Testing strategy
Tested manually.
Type of change