Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FdoSecrets: reject setting refs via the API #7043

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

Aetf
Copy link
Contributor

@Aetf Aetf commented Oct 13, 2021

Fixes #6802. Fixes #3992.

Check for references when setting fields calling from DBus. It still resolves references, though, so it's possible to manually create entries with references in KPXC UI.

Also added is a read-only field when reporting back attributes. This addresses the only actionable suggestion in #3992.

Testing strategy

Add unit test

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)
  • ✅ New feature (change that adds functionality)

@Aetf Aetf force-pushed the feature/fdo-reject-refs branch from 5010408 to a57d07f Compare October 13, 2021 16:58
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #7043 (05673da) into develop (b6716bd) will increase coverage by 0.01%.
The diff coverage is 87.80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7043      +/-   ##
===========================================
+ Coverage    63.61%   63.63%   +0.01%     
===========================================
  Files          330      330              
  Lines        41807    41822      +15     
===========================================
+ Hits         26595    26610      +15     
  Misses       15212    15212              
Impacted Files Coverage Δ
src/fdosecrets/objects/Item.cpp 85.61% <87.80%> (+0.43%) ⬆️
src/fdosecrets/dbus/DBusObject.h 100.00% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6716bd...05673da. Read the comment docs.

@Aetf Aetf force-pushed the feature/fdo-reject-refs branch from a57d07f to 05673da Compare October 16, 2021 20:05
@droidmonkey droidmonkey added this to the v2.7.0 milestone Oct 24, 2021
@droidmonkey droidmonkey merged commit 2a9d92f into keepassxreboot:develop Oct 24, 2021
@Aetf Aetf deleted the feature/fdo-reject-refs branch January 25, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential security issue with secret service Secret service not finding Username field, other issues
4 participants