Implement configurable default auto-type delay (fixes #699) #703
Conversation
src/gui/SettingsWidgetGeneral.ui
Outdated
| </widget> | ||
| </item> | ||
| <item> | ||
| <widget class="QSpinBox" name="autoTypeDelaySpinBox"> |
There was a problem hiding this comment.
Please use a proper grid layout. One column for the labels (aligned right) and one column for the input widgets.
There was a problem hiding this comment.
Right, the global auto-type shortcut was already hacked together like this so I just continued the tradition. Just to clarify: you want me to wrap both of them in a grid like "Timeouts" is in "Security"?
There was a problem hiding this comment.
It doesn't have one because it's the only option like that on this tab. But as soon as you have two or more, you need a grid to align them. So yes, please wrap those two options in a grid.
|
After addressing my review change request, please replay your changes on top of release/2.2.1 instead of develop (you can re-use the same branch by force-pushing, so we don't need a new PR). |
Additionally this fixes the increased delay when you had your own custom delay configured and it always added 25ms on top of it.
hifi
force-pushed
the
autotype-delay-override
branch
from
121ca17 to
10e78d9
Compare
|
Changed to grid layout and rebased against release/2.2.1.
|
|
Thanks for your adjustments. Only thing missing: the two labels need to be right-aligned and you may not want to stretch the time field all the way to the right. |
hifi
force-pushed
the
autotype-delay-override
branch
from
10e78d9 to
933ccce
Compare
|
Sorry, my oversight. Fixed now.
|
hifi
force-pushed
the
autotype-delay-override
branch
from
933ccce to
a032945
Compare
|
|
|
Any chance of another release soon with the many changes committed and merged so far? In particular, this feature of a configurable delay (or no delay, as in versions prior to v2.2.0) has a big impact on usability with long passwords. |
- Corrected multiple snap issues [#934, #1011] - Corrected multiple custom icon issues [#708, #719, #994] - Corrected multiple Yubikey issues [#880] - Fixed single instance preventing load on occasion [#997] - Keep entry history when merging databases [#970] - Prevent data loss if passwords were mismatched [#1007] - Fixed crash after merge [#941] - Added configurable auto-type default delay [#703] - Unlock database dialog window comes to front [#663] - Translation and compiling fixes
phoerious
added
pr: new feature
Adds both solutions presented in issue #699.
Description
All platform dependant hardcoded auto-type delays were removed in favor of a configurable default. UI was added to configure the delay which defaults to 25ms as specified.
Motivation and context
Issue #699.
How has this been tested?
Only on Linux with three different auto-type entries:
Tested the default at 0 ms, 25 ms and 500 ms. All work and are overridable by the sequence {DELAY=X} option.
Screenshots (if appropriate):
Types of changes
Checklist: