Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct naming of newly generated keyx files #7010

Merged
merged 1 commit into from
Oct 3, 2021
Merged

Conversation

droidmonkey
Copy link
Member

Fixes #6040

Testing strategy

Tested on Windows and macOS

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added the bug label Oct 2, 2021
@droidmonkey droidmonkey added this to the v2.7.0 milestone Oct 2, 2021
@droidmonkey droidmonkey requested a review from phoerious October 2, 2021 22:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2021

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.68%. Comparing base (6c18b10) to head (acb12e7).
Report is 598 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/databasekey/KeyFileEditWidget.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7010   +/-   ##
========================================
  Coverage    63.68%   63.68%           
========================================
  Files          330      330           
  Lines        41601    41601           
========================================
+ Hits         26491    26493    +2     
+ Misses       15110    15108    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey droidmonkey merged commit d82abf0 into develop Oct 3, 2021
@droidmonkey droidmonkey deleted the fix/keyx-naming branch October 3, 2021 11:32
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected key filename extension
3 participants