Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to sort groups using shortcut keys #6999

Merged

Conversation

pruthig
Copy link
Contributor

@pruthig pruthig commented Sep 29, 2021

The code changes in this pull requests pertain to issue # 6720 ( Add shortcut keys to sort groups in ascending/descending order )
To realize this functionality, I've added shortcut keys - [Ctrl + Key_UP_ARROW] to sort the groups in descending order and [Ctrl + Key_DOWN_ARROW] to sort in ascending order.

Fixes #6720

Screenshots

When [Ctrl + Key_UP_ARROW] is pressed

image

When [Ctrl + Key_DOWN_ARROW] is pressed

image

Testing strategy

I manually tested the changes on my Windows 10 machine.

Type of change

  • ✅ New feature (change that adds functionality)

@pruthig pruthig marked this pull request as ready for review September 29, 2021 14:15
src/gui/group/GroupView.cpp Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #6999 (6ce6499) into develop (cc39f9e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6999   +/-   ##
========================================
  Coverage    64.58%   64.59%           
========================================
  Files          326      326           
  Lines        40727    40734    +7     
========================================
+ Hits         26303    26309    +6     
- Misses       14424    14425    +1     
Impacted Files Coverage Δ
src/gui/group/GroupView.cpp 74.23% <100.00%> (+2.00%) ⬆️
src/core/FileWatcher.cpp 85.54% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc39f9e...6ce6499. Read the comment docs.

@droidmonkey droidmonkey added this to the v2.7.0 milestone Sep 29, 2021
@pruthig
Copy link
Contributor Author

pruthig commented Sep 30, 2021

@droidmonkey Hi Jonathan,
Is there some issue with Windows 10? Merge is blocked because of this.

@phoerious
Copy link
Member

Windows CI needs some attention, yes.

@droidmonkey
Copy link
Member

The unfortunate thing with this change is we can't show the keyboard shortcut on the context menu because then it would make the shortcut an application wide one since that context menu is defined at the MainWindow. I am merging this for now but I think we need to look into a smarter way to handle our context menus.

@droidmonkey droidmonkey merged commit 405d3ee into keepassxreboot:develop Oct 1, 2021
@pruthig pruthig deleted the feature/groups-sort-shortcut-keys branch October 1, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shortcuts to sort groups up/down/in/out
4 participants