-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to sort groups using shortcut keys #6999
Add feature to sort groups using shortcut keys #6999
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6999 +/- ##
========================================
Coverage 64.58% 64.59%
========================================
Files 326 326
Lines 40727 40734 +7
========================================
+ Hits 26303 26309 +6
- Misses 14424 14425 +1
Continue to review full report at Codecov.
|
@droidmonkey Hi Jonathan, |
Windows CI needs some attention, yes. |
The unfortunate thing with this change is we can't show the keyboard shortcut on the context menu because then it would make the shortcut an application wide one since that context menu is defined at the MainWindow. I am merging this for now but I think we need to look into a smarter way to handle our context menus. |
The code changes in this pull requests pertain to issue # 6720 ( Add shortcut keys to sort groups in ascending/descending order )
To realize this functionality, I've added shortcut keys - [Ctrl + Key_UP_ARROW] to sort the groups in descending order and [Ctrl + Key_DOWN_ARROW] to sort in ascending order.
Fixes #6720
Screenshots
When [Ctrl + Key_UP_ARROW] is pressed
When [Ctrl + Key_DOWN_ARROW] is pressed
Testing strategy
I manually tested the changes on my Windows 10 machine.
Type of change