Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete-entry command to Browser Integration API #6899

Conversation

varjolintu
Copy link
Member

@varjolintu varjolintu commented Sep 6, 2021

Adds delete-entry command to Browser Integration API. User interaction is needed.

Only entry UUID is accepted as a parameter.
Returns success as true when entry was deleted, false if canceled.

Fixes #6887.

Testing strategy

Manually.

Type of change

  • ✅ New feature (change that adds functionality)

@purejava
Copy link

purejava commented Sep 8, 2021

I compiled your branch, implemented the delete-entry feature in my Java library that accesses KeePassXC via its build-in proxy and tried it out.

It worked like a charm! 🤩

Bildschirmfoto vom 2021-09-08 19-30-26

@varjolintu
Copy link
Member Author

I compiled your branch, implemented the delete-entry feature in my Java library that accesses KeePassXC via its build-in proxy and tried it out.

It worked like a charm! 🤩

I'm still thinking if the dialog should also show the URL just in case. There might be identical titles after all.

@droidmonkey
Copy link
Member

Can you rebase onto develop?

@varjolintu varjolintu force-pushed the feature/browser_integration_delete_entry branch from 8997118 to e51149a Compare September 21, 2021 04:23
@varjolintu
Copy link
Member Author

Can you rebase onto develop?

Sure. Done.

@droidmonkey droidmonkey merged commit 4c10e51 into keepassxreboot:develop Sep 21, 2021
@varjolintu varjolintu deleted the feature/browser_integration_delete_entry branch September 21, 2021 13:11
droidmonkey pushed a commit that referenced this pull request Oct 9, 2021
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Browser pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Browser Protocol] Request to delete entry in database
4 participants