Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Database created timestamp #6356 #6876

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Display Database created timestamp #6356 #6876

merged 2 commits into from
Aug 29, 2021

Conversation

pcolby
Copy link
Contributor

@pcolby pcolby commented Aug 28, 2021

Fixes #6356.

Screenshots

screen04

Testing strategy

The ReportsPageStatistics does not appear to have any existing unit tests setup. Happy to extend them if they do exist somewhere.

Type of change

  • ✅ New feature (change that adds (very minor) functionality)

This change adds a simple Database created entry to the database statistics report, as requested by @ghost in #6356. As suggested by @droidmonkey, it uses the timestamp of the database's root group, which seems to work well.

A couple of open questions / things I'm not sure about:

  1. I chose what felt like a natural position in the list, but happy to move as appropriate.
  2. do I need to check that m_db->rootGroup() is valid, or is it safe to assume that the db always has a root group? (happy to add a check, but doesn't appear to be the existing convention for that area of code).
  3. do I need to do anything the have the tr'd string added to the L10n files?
  4. anything else I missed / should do? 🙂

Thanks! 😊

Copy link
Member

@droidmonkey droidmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect

@droidmonkey droidmonkey added this to the v2.7.0 milestone Aug 29, 2021
@droidmonkey droidmonkey merged commit 37d29b5 into keepassxreboot:develop Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the timestamp of only the database when it was created
2 participants