Display Database created
timestamp #6356
#6876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6356.
Screenshots
Testing strategy
The
ReportsPageStatistics
does not appear to have any existing unit tests setup. Happy to extend them if they do exist somewhere.Type of change
This change adds a simple
Database created
entry to the database statistics report, as requested by @ghost in #6356. As suggested by @droidmonkey, it uses the timestamp of the database's root group, which seems to work well.A couple of open questions / things I'm not sure about:
m_db->rootGroup()
is valid, or is it safe to assume that the db always has a root group? (happy to add a check, but doesn't appear to be the existing convention for that area of code).tr
'd string added to the L10n files?Thanks! 😊