Dont Scroll up When Deleting Entry #6833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to run |
|
This code is not correct, it does not select the next entry correctly when sorted. |
droidmonkey
force-pushed
the
feature/dontScrollUpWhenDeletingEntry
branch
from
b84c59e to
92bd589
Compare
* Fix keepassxreboot#6304 - Don't cause the list view to scroll to the top when deleting any entry in the list.
droidmonkey
force-pushed
the
feature/dontScrollUpWhenDeletingEntry
branch
from
92bd589 to
5cd5d70
Compare
|
I fixed the problem and streamlined the code. |
droidmonkey
approved these changes
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting an entry it now selects the entry after the deleted section or the last entry if there isn't one after the selection.
Fixes #6304
Screenshots
Before deleting:
After deleting:
Testing strategy
Tested deleting a single entry and multiple entries at
Type of change