Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance last used directory settings #6711

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Enhance last used directory settings #6711

merged 1 commit into from
Aug 22, 2021

Conversation

shemeshg
Copy link
Contributor

@shemeshg shemeshg commented Jul 5, 2021 •
edited by droidmonkey
Loading

  • Use hash based storage for last used directories instead of a key/value for each type
  • Explicitly declare certain operations as sensitive and follow the "Remember Last Database" setting for those.
  • Introduce database backup directory location (close Remember last used backup location #6619)

Screenshots

N/A

Testing strategy

  • Deleted parameter file, and cached parameter file, Tested no exceptions.
  • Save backup to folder "X"
  • See how it reflects at parameter files
  • Ensure Save database backup, shows default at the correct folder
    TIP: # ( We expect new code to be covered by unit tests and documented with doc blocks! )
    N/A

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey droidmonkey self-requested a review July 5, 2021 21:40
@droidmonkey droidmonkey changed the title feature/LastDatabaseBackupDir Remember last used backup folder Jul 14, 2021
@droidmonkey droidmonkey added this to the v2.7.0 milestone Jul 14, 2021
@shemeshg @droidmonkey
Enhance last used directory settings
0ee48d5 
* Use hash based storage for last used directories instead of a key/value for each type
* Explicitly declare certain operations as sensitive and follow the "Remember Last Database" setting for those.
* Introduce database backup directory location (close keepassxreboot#6619)
@droidmonkey droidmonkey force-pushed the feature/LastDatabaseBackupDir branch from 216ffe7 to 0ee48d5 Compare August 14, 2021 15:51
@droidmonkey droidmonkey changed the title Remember last used backup folder Enhance last used directory settings Aug 14, 2021
@droidmonkey
Copy link
Member

I decided to overhaul this entire feature while also introducing the backup database directory. @phoerious can you give this a once over please?

@droidmonkey droidmonkey mentioned this pull request Aug 19, 2021
Closed
@droidmonkey droidmonkey merged commit 746276e into keepassxreboot:develop Aug 22, 2021
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees
No one assigned
Labels
pr: new feature Pull request that adds a new feature
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

Remember last used backup location
3 participants
@shemeshg @droidmonkey @phoerious