Internalize ykcore into code base #6654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
added
feature: Hardware Keys
pr: refactoring
droidmonkey
force-pushed
the
refactor/internalize-ykcore
branch
from
d504a6e to
9e88fc4
Compare
phoerious
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
I guess this is fine. It's mostly external code that we've already been using for a long time and I don't see major blunders after a quick read-through.
One question, though: since we control the code now and this already depends on libusb, can we finally support USB hotplug events so we can get rid of the obnoxious refresh button and polling behaviour?
|
Yes we can add a signal when a USB device is plugged in to kickoff a refresh automatically. |
droidmonkey
force-pushed
the
refactor/internalize-ykcore
branch
from
9e88fc4 to
7cb8265
Compare
* Allow for multiple vendor ID's to be checked at once. This allows for the use of one tracking index, streamlining KPXC code. * Remove support for libusb 0.x on Linux * Better handling of USB errors during initial key query. Output warnings to console.
droidmonkey
force-pushed
the
refactor/internalize-ykcore
branch
from
7cb8265 to
7db9e3a
Compare
|
Huzzah, figured out what was wrong with building on Ubuntu 16.04.... needed to define _GNU_SOURCE to pull in the modern C Lib. |
yan12125
pushed a commit
to archlinuxcn/repo
that referenced
this pull request
Oct 2, 2021
* libusb & pcsclite: needed since keepassxreboot/keepassxc#6895 * yubikey-personalization: vendored since keepassxreboot/keepassxc#6654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yubico has officially deprecated their YubiKey Personalization Library
Some improvements to the Yubico implementation:
NOTE: I would also like to move zxcvbn and some other thirdparty code into the thirdparty subfolder.
This change is required to support Visual Studio builds
Testing strategy
Tested on Windows 10, macOS, Ubuntu, and Fedora
Type of change