Multiple fixes for MSI installer #6630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix #6242 - pinned taskbar shortcuts are not removed on upgrade or uninstall. Icons will be preserved between upgrades. * Fix #6627 - properly set checkboxes for desktop shortcut and autostart of login based on current settings during install * Add documentation shortcuts to the start menu * Auto-accept license if upgrading application
Probably most users will expect the icons to be removed on uninstall (but not on upgrade). https://stackoverflow.com/a/30336256/15047974 |
|
The Taskbar pinned icon is not added during install so we would have to go through each user's pinned icon folder and remove the keepassxc shortcut. I am not putting that in the msi, users can remove it manually. |
phoerious
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Pinned icon loses icon after MSI upgrade install #6242 - pinned taskbar shortcuts are not removed on upgrade or uninstall. Icons will be preserved between upgrades.
Fix "Launch at system startup" automatically turns on after every update #6627 - properly set checkboxes for desktop shortcut and autostart at login based on current settings during install
Add documentation shortcuts to the start menu
Auto-accept license if upgrading application
Testing strategy
Tested on Windows many many many times
Type of change