Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon url download dialog #6614

Merged

Conversation

peshevv
Copy link
Contributor

@peshevv peshevv commented Jun 9, 2021

Previously, it was a bit cumbersome to get a favicon from a URL that you did not already have from an entry. You would need to temporarily create an entry and download the favicon with the URL before discarding it.

To make this easier, I took the "download favicon" button on the Icon selection page that previously would appear if the URL field was filled into the entry, and converted it so that it is always visible and provides a dialog popup that allows the user to download favicons. This also makes it so that you can download icons that may not already be in your icon list when editing a group.

Screenshots

Screenshot_20210609_135614
Screenshot_20210609_135849

Testing strategy

Tested manually on Linux. I reused the existing favicon download implementation, so the code change just involved creating a new Dialog and altering some connection endpoints. I confirmed that the Dialog handles valid and invalid URLs properly.

Type of change

  • ✅ New feature (change that adds functionality)

@peshevv peshevv changed the title Feature/favicon download dialog Favicon download dialog Jun 9, 2021
@peshevv peshevv marked this pull request as ready for review June 9, 2021 22:44
@peshevv peshevv changed the title Favicon download dialog Add favicon download dialog Jun 9, 2021
@droidmonkey
Copy link
Member

The dialog should be pre populated with the entry's url

@peshevv peshevv force-pushed the feature/favicon-download-dialog branch 2 times, most recently from 3188a9e to b2a2a82 Compare June 9, 2021 23:32
@peshevv peshevv changed the title Add favicon download dialog Reformat file Jun 9, 2021
@peshevv peshevv changed the title Reformat file Add favicon download dialog Jun 9, 2021
@peshevv peshevv force-pushed the feature/favicon-download-dialog branch from 02d75b9 to 88e436d Compare June 10, 2021 05:03
@droidmonkey droidmonkey changed the title Add favicon download dialog Add favicon url download dialog Sep 21, 2021
@droidmonkey droidmonkey added this to the v2.7.0 milestone Oct 11, 2021
@droidmonkey droidmonkey self-requested a review November 14, 2021 04:22
src/gui/FaviconDownloadDialog.cpp Outdated Show resolved Hide resolved
src/gui/EditWidgetIcons.cpp Outdated Show resolved Hide resolved
@droidmonkey droidmonkey force-pushed the feature/favicon-download-dialog branch from 88e436d to 436ba8a Compare December 11, 2021 03:23
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2021

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.22%. Comparing base (12d16f6) to head (8c2fe39).
Report is 546 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/EditWidgetIcons.cpp 42.86% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6614      +/-   ##
===========================================
- Coverage    64.22%   64.22%   -0.00%     
===========================================
  Files          336      336              
  Lines        42369    42377       +8     
===========================================
+ Hits         27209    27214       +5     
- Misses       15160    15163       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@droidmonkey droidmonkey force-pushed the feature/favicon-download-dialog branch from 436ba8a to dd7ed90 Compare December 12, 2021 14:56
@droidmonkey droidmonkey force-pushed the feature/favicon-download-dialog branch from dd7ed90 to 8c2fe39 Compare December 12, 2021 15:35
@droidmonkey
Copy link
Member

droidmonkey commented Dec 12, 2021

I completely rewrote the code here and moved the text box directly into the Edit Icon widget. I also took this opportunity to cleanup the buttons.

image

@droidmonkey droidmonkey merged commit 4567265 into keepassxreboot:develop Dec 12, 2021
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Networking pr: new feature Pull request that adds a new feature ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants