-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favicon url download dialog #6614
Merged
droidmonkey
merged 1 commit into
keepassxreboot:develop
from
peshevv:feature/favicon-download-dialog
Dec 12, 2021
Merged
Add favicon url download dialog #6614
droidmonkey
merged 1 commit into
keepassxreboot:develop
from
peshevv:feature/favicon-download-dialog
Dec 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialog should be pre populated with the entry's url |
peshevv
force-pushed
the
feature/favicon-download-dialog
branch
2 times, most recently
from
June 9, 2021 23:32
3188a9e
to
b2a2a82
Compare
peshevv
force-pushed
the
feature/favicon-download-dialog
branch
from
June 10, 2021 05:03
02d75b9
to
88e436d
Compare
droidmonkey
changed the title
Add favicon download dialog
Add favicon url download dialog
Sep 21, 2021
droidmonkey
requested changes
Nov 24, 2021
droidmonkey
force-pushed
the
feature/favicon-download-dialog
branch
from
December 11, 2021 03:23
88e436d
to
436ba8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6614 +/- ##
===========================================
- Coverage 64.22% 64.22% -0.00%
===========================================
Files 336 336
Lines 42369 42377 +8
===========================================
+ Hits 27209 27214 +5
- Misses 15160 15163 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
droidmonkey
force-pushed
the
feature/favicon-download-dialog
branch
from
December 12, 2021 14:56
436ba8a
to
dd7ed90
Compare
droidmonkey
force-pushed
the
feature/favicon-download-dialog
branch
from
December 12, 2021 15:35
dd7ed90
to
8c2fe39
Compare
droidmonkey
approved these changes
Dec 12, 2021
phoerious
added
pr: new feature
Pull request that adds a new feature
and removed
new feature
labels
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was a bit cumbersome to get a favicon from a URL that you did not already have from an entry. You would need to temporarily create an entry and download the favicon with the URL before discarding it.
To make this easier, I took the "download favicon" button on the Icon selection page that previously would appear if the URL field was filled into the entry, and converted it so that it is always visible and provides a dialog popup that allows the user to download favicons. This also makes it so that you can download icons that may not already be in your icon list when editing a group.
Screenshots
Testing strategy
Tested manually on Linux. I reused the existing favicon download implementation, so the code change just involved creating a new Dialog and altering some connection endpoints. I confirmed that the Dialog handles valid and invalid URLs properly.
Type of change