Improve attachment handling #6606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for initial review @droidmonkey. |
phoerious
force-pushed
the
feature/improve-attachment-handling
branch
from
c8fc32a to
1ec9380
Compare
phoerious
force-pushed
the
feature/improve-attachment-handling
branch
3 times, most recently
from
59432a3 to
f1b94a7
Compare
This was referenced Jul 2, 2021
Externally opened attachments are now lifecycle-managed properly. The temporary files are created with stricter permissions and entirely random names (except for the file extension) to prevent meta data leakage. When the database is closed, the files are overwritten with random data and are also more reliably deleted than before. Changes to the temporary files are monitored and the user is asked if they want to save the changes back to the database (fixes #3130). KeePassXC does not keep a lock on any of the temporary files, resolving long-standing issues with applications such as Adobe Acrobat on Windows (fixes #5950, fixes #5839). Internally, attachments are copied less. The EntryAttachmentsWidget now only references EntryAttachments instead of owning a separate copy (which used to not be cleared properly under certain circumstances).
droidmonkey
force-pushed
the
feature/improve-attachment-handling
branch
from
f1b94a7 to
bb2c9fd
Compare
droidmonkey
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
I made an improvement to the save/discard dialog, it will only be shown once no matter how many times a file change is detected. Before it would shown another dialog for the same file many times.
I also fixed the attachment widget buttons getting scrunched up in the advanced tab of the edit entry widget.
phoerious
added
pr: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2400
Fixes #3130
Fixes #5950
Fixes #5839
Fixes #1695
Fixes #6648
Type of change