-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct write save option #6594
Conversation
09e6d6f
to
55ed3a5
Compare
55ed3a5
to
5f5a403
Compare
@droidmonkey Would if help the gvfs situation if KPXC always used a local copy to open and save? IOW: copy to local disk → open from local disk → make changes → save to local disk → copy to origin? If this is what "Temporary file moved into place" does, I wonder why that still fails? Is the problem only when saving, or could there also be an issue when opening from gvfs? A related idea is use a local temporary file but with atomic move. |
5f5a403
to
987a238
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go, just one nitpick.
* Introduced in #6438, modified signal is not blocked at the Database level when emitting is blocked. This causes infinite saving to occur when Always Save After Every Change is enabled.
* Closes #6335 * Modify application settings presentation to allow for alternative saving strategies * Transition Database::save calls to using flags to control saving behavior. Reduces boolean flags on function call. * Made direct write save option a local setting to prevent unintentional carry over between platforms.
987a238
to
c153b22
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6594 +/- ##
===========================================
- Coverage 63.68% 63.67% -0.01%
===========================================
Files 330 330
Lines 41601 41617 +16
===========================================
+ Hits 26491 26496 +5
- Misses 15110 15121 +11 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Also fixes infinite save bug when saving fails:
Screenshots
Testing strategy
Tested all three options (Atomic, Non-Atomic Temp File, and Non-Atomic Direct Write) on Windows and Linux
Tested against GVFS on Gnome 3
Type of change