Add a context menu entry to delete entries from health check reports #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the suboptimal framing in the screenshot 🙃 |
|
The workflow in the linked issue suggests that we could have a delete entry button in the edit entry widget when triggered from the report. Should I try to have this as well? |
|
Technically we could but the edit entry workflow needs to be greatly improved. I prefer a context menu item only for now. If it's easy to implement and works then edit entry as well. |
xvallspl
force-pushed
the
feature/delete-entry-from-reports
branch
from
6b9346d to
28ee8e2
Compare
|
What I would prefer is not blind deletion from the report, but a context action that says "Show affected entries", which sends you back to the main view but with a filter set to only those entries. |
droidmonkey
force-pushed
the
feature/delete-entry-from-reports
branch
from
28ee8e2 to
9ed679c
Compare
|
I made a ton of changes:
|
* Introduce GuiTools namespace to collect shared GUI prompts and actions * Add functionality to HIBP report to mirror health check report
droidmonkey
force-pushed
the
feature/delete-entry-from-reports
branch
from
9ed679c to
bfd6bef
Compare
droidmonkey
approved these changes
May 31, 2021
droidmonkey
changed the title
pull bot
pushed a commit
to Mu-L/keepassxc
that referenced
this pull request
May 31, 2021
…eepassxreboot#6537) * Closes keepassxreboot#4986 - Allow deleting entries from the reports view * Closes keepassxreboot#4533 - Exclude & delete multiple entries in a report * Also allow deleting selected entries using the delete key * Introduce GuiTools namespace to collect shared GUI prompts and actions * Add functionality to HIBP report to mirror health check report Co-authored-by: Jonathan White <[email protected]>
pull bot
pushed a commit
to rayou/keepassxc
that referenced
this pull request
May 31, 2021
…eepassxreboot#6537) * Closes keepassxreboot#4986 - Allow deleting entries from the reports view * Closes keepassxreboot#4533 - Exclude & delete multiple entries in a report * Also allow deleting selected entries using the delete key * Introduce GuiTools namespace to collect shared GUI prompts and actions * Add functionality to HIBP report to mirror health check report Co-authored-by: Jonathan White <[email protected]>
phoerious
added
pr: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #4986
Ideally we would be able to select multiple entries and delete them at once, but it would require deeper changes in the widget. This is a start.
Screenshots
Type of change