-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch KeePassXC password generator popup from the extension #6529
Launch KeePassXC password generator popup from the extension #6529
Conversation
fb71206
to
b2b4a0b
Compare
06ba242
to
c5e1d94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6529 +/- ##
===========================================
+ Coverage 63.77% 63.93% +0.17%
===========================================
Files 330 330
Lines 41857 41750 -107
===========================================
+ Hits 26691 26692 +1
+ Misses 15166 15058 -108 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Not working yet, even if I made the fixes. If the password dialog is closed, after that it doesn't fill anymore when launched again. |
Fixed a bug where the signal was connected multiple times (on every new request). Moved the lambda to the constructor so we can make sure it's only connected once. |
This works REALLY well, great job @varjolintu. As a note, when you connect a lambda function to a signal, you need to provide a context (the third parameter in |
77b1abb
to
fbd3495
Compare
Add support for launching the password generator popup from the browser and returning the generated password.
Removes all password related settings from BrowserSettings class.
Related KeePassXC-Browser PR: keepassxreboot/keepassxc-browser#1329
Fixes #6473.
Testing strategy
Manually.
Type of change