Introduce security option to enable copy on doubleclick #6433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a checkbox in the security section of the preferences to enable the current feature (now disabled by default) of copying DatabaseView entries columns, such as username and password, on double click. Addresses issue #1575.
droidmonkey
requested changes
Apr 21, 2021
|
Any ideas on how to test this? |
|
Just test manually, this is low impact and automated tests involve timing and other crap that regularly breaks testing in CI |
|
Then this one should be ready to go if it passes the CI |
droidmonkey
requested changes
Apr 21, 2021
|
Need to run |
|
Sorry, I guess my clangd plugin is misconfigured |
|
Could also just be a different version. Make sure you have the latest. |
droidmonkey
changed the title
pull bot
pushed a commit
to tank0226/keepassxc
that referenced
this pull request
Apr 24, 2021
…ot#6433) * Fix keepassxreboot#1575 - option is disabled by default
pull bot
pushed a commit
to iloeng/keepassxc
that referenced
this pull request
Apr 24, 2021
…ot#6433) * Fix keepassxreboot#1575 - option is disabled by default
pull bot
pushed a commit
to SammyEnigma/keepassxc
that referenced
this pull request
Apr 24, 2021
…ot#6433) * Fix keepassxreboot#1575 - option is disabled by default
pull bot
pushed a commit
to NeatNerdPrime/keepassxc
that referenced
this pull request
Apr 24, 2021
…ot#6433) * Fix keepassxreboot#1575 - option is disabled by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a checkbox in the security section of the preferences to enable the
current feature (now disabled by default) of copying DatabaseView entries
columns, such as username and password, on double click. Addresses issue #1575.
Screenshots
Testing strategy
Figuring this out
Type of change