Browser Support: Use advanced password generator settings if enabled #6386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore the advanced character classes when advanced mode is disabled like the PasswordGeneratorWidget does Fixes: keepassxreboot/keepassxc-browser#1297
|
I hate that we are basically duplicating code here to achieve similar behavior. I would rather refactor this whole thing to use the actual password generator pop-up and not some janky in browser generator. |
|
Closed because of #6529. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the advanced character classes when advanced mode is disabled like the PasswordGeneratorWidget does
Fixes: keepassxreboot/keepassxc-browser#1297
Type of change