SSH Agent: Allow using database path to resolve keys #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need an option for this? Other behavior in the app is that a relative path is always resolved based off the database location. We also have the {DB_DIR} placeholder. |
|
KeeAgent uses the working directory according to their documentation so this is would be a compatibility breaking change to change the default behavior. I don't mind breaking it but someone probably would. Which approach we take? |
|
What's the behavior if the setting is disabled? It just fails? Assumes absolute? |
|
Relative to working directory. So pretty random but it is user controllable at will. |
|
I have no problem breaking that behavior |
hifi
force-pushed
the
feature/sshagent-database-rel-path
branch
from
73189b5 to
f78a73e
Compare
|
Removed the configuration options. I also believe it's more correct to be relative to the database by default. |
droidmonkey
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly breaks the encapsulation of KeeAgentSettings now depending on SSHAgent for the global configuration option but it's not too bad.
This has a minor header include conflict with #6209 and can wait for it to be merged first.
I will do a class forwards declaration cleanup later for all SSH Agent stuff so this continues the tradition of including the classes for now.
Closes #5225
Screenshots
Testing strategy
Type of change