Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Type: Shortcut to search all entries, checkbox, default selection #6361

Conversation

hifi
Copy link
Member

@hifi hifi commented Mar 30, 2021

  • Change Auto-Type dialog radios to a single checkbox, Ctrl-F shortcut to toggle on/off.
  • Don't automatically select first item if we are doing global search and the query is empty

These improve UX.

Screenshots

image

Filter or Search... has been updated to plain Search...

Testing strategy

Manually on linux. Focus works correctly.

Type of change

  • ✅ Breaking change (causes existing functionality to change)

@hifi hifi force-pushed the feature/autotype-dialog-search-shortcut branch from f702e86 to 534cbea Compare March 31, 2021 04:17
When we default to full database search it's possible the user
would select the first match without a query string by accident.

In this case when our query is empty we don't select anything and
you need to either type something or press down to select the
first item.
@hifi hifi changed the title Auto-Type: Shortcut to search all entries, checkbox Auto-Type: Shortcut to search all entries, checkbox, default selection Mar 31, 2021
@droidmonkey
Copy link
Member

droidmonkey commented Apr 1, 2021

I added a few keyboard shortcuts and a nice help popup:
image
Also fixed a couple areas where crashes or bad behavior could occur.

@droidmonkey droidmonkey force-pushed the feature/autotype-dialog-search-shortcut branch from 0b8aa3d to 01912d3 Compare April 1, 2021 00:48
@droidmonkey droidmonkey force-pushed the feature/autotype-dialog-search-shortcut branch from 01912d3 to 2338da0 Compare April 1, 2021 01:19
@droidmonkey droidmonkey merged commit 371bd2e into keepassxreboot:develop Apr 1, 2021
@droidmonkey droidmonkey added this to the v2.7.0 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants