Auto-Type: Allow actions to fail and be retried

[hifi]

AutoTypeActions are required to return a result object with information if they can be retried or not. An error string is also provided to show a user friendly message why said action did not succeed if even after retries it keeps failing.

This is a prerequisite for waiting for modifier keys to be released on X11 and can be used to add friendly error messages to any executor.

We want to merge this before #6351 so it can be refactored to make use of the retry logic here.

Only X11 is actually implemented and others are just stubbed in.

Testing strategy

Manually.

Type of change

• ✅ New feature (change that adds functionality)

[droidmonkey]

I feel like this should just be a QPair<AutoTypeAction::ResultEnum, QString> where the result enum is "Ok, Retry, Failed" and the QString contains the error message (optional). The below is a lot of boiler plate to provide the same end result.

[hifi]

Kind of but it's not very ergonomic to use enums and QPairs and the code isn't self explanatory compared to the boilerplate version.

IIRC I would need to return something like this:

return qMakePair(AutoTypeActionResult_Failed, tr("Well duh."));

It doesn't look very pretty to use a QPair as a return type either so it makes declarations more verbose as well. Also need to remember returning an Ok looks a bit weird as you need to create an empty string. The enum values need to be globally unique unless namespaced.

[droidmonkey]

Doesn't the enum value get wrapped in the class namespace? So it would be AutoTypeAction::Ok

I am not against the current version it is just verbose. We can keep it.

[hifi]

Indeed, the enum would actually work like that but it would reserve the words inside the class. Not necessarily an issue.

Though as discussed on IRC and here I'll keep this implementation for now and we'll refactor later if we feel the urge to either use a more global result class or just get rid of it.