Auto-Type: Abort keystroke if modifiers held on X11 #6351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hifi
force-pushed
the
fix/autotype-modifiers-mangling
branch
from
0fceff0 to
7b2439b
Compare
This was referenced Mar 28, 2021
|
Is this ready for merge? |
|
Need to rebase so the retry logic is used. |
Releasing lock modifiers during Auto Type does not work reliably on X11 and can cause some modifiers to get stuck and more precisely layout switching can get stuck. Instead of trying to find out what modifiers to release we can just abort when the user is holding modifiers that may affect the typing sequence. Fixes keepassxreboot#6350
hifi
force-pushed
the
fix/autotype-modifiers-mangling
branch
from
7b2439b to
f8d057f
Compare
droidmonkey
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing lock modifiers during Auto Type does not work reliably on X11 and can cause some modifiers to get stuck and more precisely layout switching can get stuck.
Instead of trying to find out what modifiers to release we can be dumb and just abort when the user is holding modifiers that may affect the typing sequence.
With #6357 merged we return a retry request if modifiers are held.
Fixes #6350 and #1915 after #6357 is merged and this is rebased on top of it.
Testing strategy
See #6350
Type of change