Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for triggering Global Auto-Type from browser extension #6272

Merged

Conversation

varjolintu
Copy link
Member

@varjolintu varjolintu commented Mar 13, 2021

Added support for triggering Global Auto-Type from the browser extension, where a browser-specific keyboard shortcut can be defined for it.

Related PR: keepassxreboot/keepassxc-browser#1265

Testing strategy

Manually. Also tested with a build that doesn't have Auto-Type enabled at all.

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey
Copy link
Member

droidmonkey commented Mar 13, 2021

Ideally I would want to start the autotype process by filling in the stripped-down URL for database search, like this:

image

@varjolintu
Copy link
Member Author

@droidmonkey Got it.

@droidmonkey
Copy link
Member

Looks like you still have some build failures on tests

src/autotype/AutoType.cpp Outdated Show resolved Hide resolved
src/autotype/AutoType.h Outdated Show resolved Hide resolved
src/browser/BrowserAction.cpp Show resolved Hide resolved
src/browser/BrowserAction.cpp Show resolved Hide resolved
src/browser/BrowserService.cpp Outdated Show resolved Hide resolved
src/gui/DatabaseWidget.cpp Show resolved Hide resolved
src/gui/DatabaseWidget.cpp Outdated Show resolved Hide resolved
src/gui/osutils/OSUtilsBase.h Outdated Show resolved Hide resolved
@varjolintu
Copy link
Member Author

Changes made but I need to rebase this whole thing. Also, there are some changes to the Auto-Type triggering with the current development branch. Need to test this again after everything is in order.

@varjolintu varjolintu force-pushed the feature/autotype_from_browser branch from 01d2e05 to 87f13d7 Compare October 10, 2021 11:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Attention: Patch coverage is 27.50000% with 58 lines in your changes missing coverage. Please review.

Project coverage is 63.63%. Comparing base (be6835e) to head (a905d66).
Report is 592 commits behind head on develop.

Files with missing lines Patch % Lines
src/browser/BrowserAction.cpp 10.64% 42 Missing ⚠️
src/gui/DatabaseTabWidget.cpp 16.67% 5 Missing ⚠️
src/autotype/AutoType.cpp 72.73% 3 Missing ⚠️
src/autotype/AutoTypeSelectDialog.cpp 0.00% 3 Missing ⚠️
src/gui/DatabaseWidget.cpp 25.00% 3 Missing ⚠️
src/browser/BrowserService.cpp 77.78% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6272      +/-   ##
===========================================
- Coverage    63.68%   63.63%   -0.04%     
===========================================
  Files          330      330              
  Lines        41605    41646      +41     
===========================================
+ Hits         26493    26501       +8     
- Misses       15112    15145      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@varjolintu varjolintu force-pushed the feature/autotype_from_browser branch from 87f13d7 to a905d66 Compare October 10, 2021 12:13
@droidmonkey droidmonkey merged commit c7cdce6 into keepassxreboot:develop Oct 11, 2021
@varjolintu varjolintu deleted the feature/autotype_from_browser branch October 11, 2021 03:43
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Browser pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants