Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group clone action #6124

Merged
merged 1 commit into from
Aug 8, 2021
Merged

Add group clone action #6124

merged 1 commit into from
Aug 8, 2021

Conversation

stuzer05
Copy link
Contributor

@stuzer05 stuzer05 commented Feb 15, 2021

Adds ability to duplicate groups with its subgroups and entries (root group cannot be duplicated).

Clone group action is available both from group context and main window menus.

After clicking the "clone group" menu button "add group" window will open where you can change the cloned group or cancel cloning.

Close #3796

Screenshots

2021-02-15-043734_1920x1080_scrot
2021-02-15-043747_1920x1080_scrot
2021-02-15-043755_1920x1080_scrot

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey
Copy link
Member

You can already do this with drag/drop. Drag the group, hold CTRL, then drop where you want it. A copy of the entire group will be made.

@stuzer05
Copy link
Contributor Author

You can already do this with drag/drop. Drag the group, hold CTRL, then drop where you want it. A copy of the entire group will be made.

Well, it's not that obvious I guess. Having a context menu option will remove the obscurity behind group cloning functionality. I think many users (incl. me) would never know it existed is not randomly holding ctrl while drag&drop, although this feature is useful for some users.

@droidmonkey
Copy link
Member

I would like to connect the two code pieces for this instead of duplicating the capability.

@droidmonkey droidmonkey added this to the v2.7.0 milestone Feb 15, 2021
@droidmonkey droidmonkey added the ux label Feb 15, 2021
@droidmonkey droidmonkey self-requested a review February 15, 2021 17:03
@droidmonkey droidmonkey changed the title Implements 3796: Added group cloning action Add group clone action Feb 15, 2021
@droidmonkey droidmonkey merged commit 304cb44 into keepassxreboot:develop Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to duplicate / clone / copy group with subgroups
2 participants