Add search 'by-path' url for browser #5535
Conversation
|
As the path is known, I think one should avoid the search. What do you think @piegamesde ? |
src/browser/BrowserService.cpp
Outdated
| } | ||
| return handleURL(entry->url(), url, submitUrl); | ||
| } | ||
|
|
||
| QString BrowserService::getPath(Entry* entry) const |
There was a problem hiding this comment.
I'm really not sure, but could this method be added as method of Entry instead? It feels like it would be better to put it there.
|
I would rather we implement the proposed reference syntax from #5369. This would apply to the by-uuid previous merge implementation as well. Obviously this url reference syntax would be implemented globally, not just in the browser service. |
|
Yes, you are right.In case that the proposal is accepted, I can adapt my change proposal accordingly, as well as refactor the by-uuid syntax. The question would be, if you already require the full implementation of the syntax? E.g. retrieving history items etc via the browser interface. |
|
We can merge this, once fixed up, for now and easily replace it with the new syntax. |
|
As far as I am concerned, this PR is ready for review. |
|
@droidmonkey, @piegamesde Do I need to add something here? |
|
The changes are fine for me, but I can't judge how this interacts with #5369. |
Well, once #5369 is implemented, we would need to adjust the URL here. See #5535 (comment) Of course, IMO, the implementation of #5369 would imply the implementation of a generic search handler such that the bells-and-whistles for |
|
I cleaned up the code a bit, ready to merge once CI completes |
phoerious
added
pr: new feature
This PR adds the option to use the URL scheme to search for an entry by path. Hence, tools implementing the keepassxc-browser API can use a credential's path to request a specific credential.
The code currently reuses the strategy implemented by @piegamesde in #4763.
Testing strategy
Type of change