Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/apple watch support #5526

Merged

Conversation

tqml
Copy link
Contributor

@tqml tqml commented Oct 8, 2020

I changed the LAPolicy flags so authentication is possible with TouchID or Apple Watch (closes #5337 ). This feature requires at least Catalina (10.15) so I added an availability check which only enables it on Catalina and newer.

Testing strategy

This PR should only be a draft to see if the simple approach works. Unfortunately I'm not able to test it. I suspect the problem is because of missing code signing (the original TouchID only implementation doesn't work for me either)

Any hints are much appreciated!

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey
Copy link
Member

Awesome, now to setup that iWatch I bought to test this...

And yes, you need to sign the app to get sec controls to work on Catalina ÷

@mbrinkme
Copy link

mbrinkme commented Nov 6, 2020

Nice to see that you have an approach to use the apple watch to unlock keepassxc. 👍

@droidmonkey
Copy link
Member

I tried using this but I couldn't get the watch unlock feature to work on the Mac at all, even in the lock screen. Anyone have pointers on this? I disabled touchid and it still won't prompt for watch unlock.

@vaheder
Copy link

vaheder commented Jan 12, 2021

I tried using this but I couldn't get the watch unlock feature to work on the Mac at all, even in the lock screen. Anyone have pointers on this? I disabled touchid and it still won't prompt for watch unlock.

You've enabled "Use your Apple Watch to unlock apps and your Mac" in Security and Privacy Settings? I've also encountered problems with USB 3.0 devices connected to my Mac and the Apple Watch unlock feature; it has to do with radio interference caused by the high speed signaling, if you can believe it. Try it with nothing connected to your laptop (I assume since you mentioned TouchID). Looking forward to this feature!

@droidmonkey
Copy link
Member

Yah I enabled that setting, maybe I needed to reboot?

@vaheder
Copy link

vaheder commented Jan 12, 2021

Only other thing I can think of is to make sure you're properly logged into the same iCloud account on both iPhone and Mac, but I would imagine you wouldn't be able to enable the setting if that wasn't true already.

@vaheder
Copy link

vaheder commented Jan 12, 2021

Just built this to test it but didn't work for me. I can't sign the app properly, so it may be a side effect of that. I enabled TouchID for the database (I'm assuming the watch unlock follows the same code path) but it didn't seem to work, and the "TouchID for Quick Unlock" is always unchecked, even after correctly unlocking the database.

@droidmonkey
Copy link
Member

You need to sign the app to make touchid work

@Tobisaninfo
Copy link

That is a nice approach for all mac users without TouchID. Like to see this in the future.

* Allow using a paired Apple Watch to authenticate to the secrets store in addition to TouchID.
* Closes keepassxreboot#5337
@droidmonkey droidmonkey force-pushed the feature/apple-watch-support branch from 69c35f1 to e508684 Compare September 21, 2021 02:23
@droidmonkey droidmonkey marked this pull request as ready for review September 21, 2021 02:44
@droidmonkey droidmonkey merged commit 34ed63f into keepassxreboot:develop Sep 21, 2021
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: macOS pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open database using Apple Watch "double tap" confirmation feature on MacOS
6 participants