Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout and alignment of Entry and Group edit views #5424

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

droidmonkey
Copy link
Member

Screenshots

BEFORE:
image

AFTER:
image

Testing strategy

Tested on Windows and Ubuntu 16.04

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

* Fixes #5321 - Text alignment in the general tab of the entry and group edit views is fixed
* Fixes #5300 - Errant scrollbar in the general tab is fixed
* Fixes #4852 - Tabbing into notes field works as expected. To tab out, currently only Shift+Tab works.
@droidmonkey
Copy link
Member Author

I guess the expired text also needs to be aligned now too

src/gui/entry/EditEntryWidget.cpp Show resolved Hide resolved
src/gui/styles/base/basestyle.qss Show resolved Hide resolved
@droidmonkey
Copy link
Member Author

For the record, I looked into aligning the QDateTime widget and that too is a hacked widget with no ability to even access the lineEdit() control like QComboBox because they made it a protected function.

@phoerious
Copy link
Member

phoerious commented Sep 25, 2020

I am fine with merging this for 2.6.2, but we should find a better solution for aligning the fields for future versions.

@droidmonkey
Copy link
Member Author

droidmonkey commented Sep 25, 2020

I'm fine with that. Entry templates may end up resolving this

@droidmonkey droidmonkey dismissed phoerious’s stale review September 26, 2020 13:25

Approved by comment

@droidmonkey droidmonkey merged commit 55e4889 into release/2.6.2 Sep 26, 2020
@droidmonkey droidmonkey deleted the hotfix/phantom-scrollbar branch September 26, 2020 13:25
phoerious added a commit that referenced this pull request Oct 21, 2020
Added

- Add option to keep window always on top to view menu [#5542]
- Move show/hide usernames and passwords to view menu [#5542]
- Add command line options and environment variables for changing the config locations [#5452]
- Include TOTP settings in CSV import/export and add support for ISO datetimes [#5346]

Changed

- Mask sensitive information in command execution confirmation prompt [#5542]
- SSH Agent: Avoid shortcut conflict on macOS by changing "Add key" to Ctrl+H on all platforms [#5484]

Fixed

- Prevent data loss with drag and drop between databases [#5536]
- Fix crash when toggling Capslock rapidly [#5545]
- Don't mark URL references as invalid URL [#5380]
- Reset entry preview after search [#5483]
- Set Qt::Dialog flag on database open dialog [#5356]
- Fix sorting of database report columns [#5426]
- Fix IfDevice matching logic [#5344]
- Fix layout issues and a stray scrollbar appearing on top of the entry edit screen [#5424]
- Fix tabbing into the notes field [#5424]
- Fix password generator ignoring settings on load [#5340]
- Restore natural entry sort order on application load [#5438]
- Fix paperclip and TOTP columns not saving state [#5327]
- Enforce fixed password font in entry preview [#5454]
- Add scrollbar when new database wizard exceeds screen size [#5560]
- Do not mark database as modified when viewing Auto-Type associations [#5542]
- CLI: Fix two heap-use-after-free crashes [#5368,#5470]
- Browser: Fix key exchange not working with multiple simultaneous users on Windows [#5485]
- Browser: Fix entry retrieval when "only best matching" is enabled [#5316]
- Browser: Ignore recycle bin on KeePassHTTP migration [#5481]
- KeeShare: Fix import crash [#5542]
- macOS: Fix toolbar theming and breadcrumb display issues [#5482]
- macOS: Fix file dialog randomly closing [#5479]
- macOS: Fix being unable to select OPVault files for import [#5341]
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bugfix Pull request that fixes a bug user interface
Projects
None yet
2 participants