Use Alt+Tab on macOS to switch between databases #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…switcher) shortcut to Alt+Tab. Ctrl+Tab does not work unfortunately.
droidmonkey
requested changes
Sep 12, 2020
droidmonkey
requested changes
Sep 12, 2020
droidmonkey
approved these changes
Sep 15, 2020
droidmonkey
changed the title
|
This is great! Thanks for the PR. |
|
@pur80a Looks like the QT bug is still unresolved, so someone can find a good hack or workaround then I don't think this can be fixed. https://bugreports.qt.io/browse/QTBUG-8596 The bug priority is "P2: Important" but I doubt anyone is actively thinking about it. You could try asking in the bug ticket if there's anything you can do to help them. :) |
|
I understand. Thanks for the quick reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Ctrl+Tab (well, it was actually Cmd+Tab, but that is the macOS task switcher) shortcut to Alt+Tab. Ctrl+Tab does not work unfortunately, see https://bugreports.qt.io/browse/QTBUG-8596 and https://stackoverflow.com/questions/20694919/c-qt-osx-qtmetaqtkey-tab-shortcut-bind.
I also changed Ctrl+PageDown for consistency, but I can change that back. I can also change the variable name. I wanted to quickly create this PR with the gist of the proposed change in order to get feedback.
It appears that there is some kind of workaround that Chrome utilizes (https://bugreports.qt.io/browse/QTBUG-8596?focusedCommentId=321526&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-321526). But I have not idea if it is feasible or how to implement it.
I also noticed that
KeePassXC_KeyboardShortcuts.htmlis not customized per platform. There should be a column per OS, or an OS-specific file should be included depending on the build.Screenshots
N/A
Testing strategy
I was able to compile and run the application.
Type of change