Add keyfile option to keepassxc cli import cmd

[Colfenor]

Fixes #5311

Basically added the add keyFile logic from the create
command to the import command and moved the loadFileKey() function
to the Utils class since it is now used in both create & import classes.

Testing strategy

export an existing Database with a keyfile to .xml

import it again using the keyfile option in the import command: (e.g.)
./keepassxc-cli import -k ~/test.key ~/test.xml ~/test.kdbx

at the current implementation state the filePath parameters have to be in that exact order.

Type of change

• ✅ New feature (change that adds functionality)

[louib]

Hi @Colfenor ! Thanks for the PR 🙏

There is a manpage for the CLI located in docs/man/ which would need to be updated with the new option.

Tests for the CLI are located in tests/TestCli.cpp and I think it's definitely worth it to add tests for the new option. For the CLI tests to run, you need to configure the project with -DWITH_GUI_TESTS=ON. You probably can use the test for the create command as a template.

Also, there seems to be some formatting issues with the PR. Formatting can be performed automatically by calling make format from the build/ directory. See https://github.com/keepassxreboot/keepassxc/blob/develop/.github/CONTRIBUTING.md#coding-styleguide for details.

[Colfenor]

Hi @louib ! Thanks a lot for your info on the make format option and on the gui test option.
I added the man-page documentation, fixed format issues and added import cmd tests.

[louib]

The password setting behavior is not the same for the db-create and import commands. By default, we don't ask for a password when creating the db, but we do when importing. I feel like the behavior should be the same, whichever we choose. @droidmonkey what do you think?

[droidmonkey]

The behavior should be the same because its the same action "create a db" just one is blank the other has data in it.

[Colfenor]

The behavior should be the same because its the same action "create a db" just one is blank the other has data in it.

okidok, I added the SetPasswordOption to the import command and updated man-page + tests.
Moreover the db-create and import cmd only accept -p -k in this exact order. I feel like this should be further clarified in the man pages, that exactly this order is accepted.

[louib]

Moreover the db-create and import cmd only accept -p -k in this exact order.

Is it not because the -k option takes an argument and not the -p option? I feel like -k key_file_path.txt -p should work, no?

[Colfenor]

Moreover the db-create and import cmd only accept -p -k in this exact order.

Is it not because the -k option takes an argument and not the -p option? I feel like -k key_file_path.txt -p should work, no?

Ah yes, I missed the argument. I just tested your statement, and can confirm that -k key_file_path.txt -p works :)

[louib]

@Colfenor looking good! Can you do one last rebase?

[Colfenor]

@Colfenor looking good! Can you do one last rebase?

yay ! I'm still a bit new to git rebasing, do you want me to rebase this branch on top of develop ?
like:
git checkout myFeatureBranch
git rebase develop

[droidmonkey]

That'll do it, but make sure everything looks good prior to force pushing it back up

[Colfenor]

That'll do it, but make sure everything looks good prior to force pushing it back up

Ok thanks for clarification ! I hope it worked out ?

[louib]

Awesome work @Colfenor , thx a lot for your contribution 🎉 🍾

[louib]

@Colfenor Ubuntu tests are failing though. Are they passing locally?

[Colfenor]

@Colfenor Ubuntu tests are failing though. Are they passing locally?

@louib I checked the TeamCity build log (via guest login) and apparently the TestPassphraseGenerator.cpp -Test failed,
I saw this randomly fail on other commits I've made and assume this generates in rare cases combinations which are not matching QRegularExpression regex("^([A-Z][a-z]* ?)+$"); and therefore it fails ?

I haven't touched this test in this PR.

[droidmonkey]

DONE! Great work 🎉

[Colfenor]

Thank you :) and thanks a lot for reviewing & support !