-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password rating column to entry view #4797
Add password rating column to entry view #4797
Conversation
I would just use a three tier rating system: Red, Yellow, Green. The shades are too similar (although this is a ding on the health report colors really). |
Unsure of failure on Windows testCli, will investigate
At the moment, I use the password health color palette. I utilize the same implementation as the password generator widget of "critical" coloring for the "Bad" and "Poor" category, "bad" coloring for "weak" passwords, and "good"/"excellent" for their respective ratings. I was thinking combining the "good" and "excellent" ratings to eliminate confusion with shading. Would that be appropriate? |
There should also be no column reordering. Those lines are an artefact from before our settings refactor. 2.6 will simply reset users' column settings, no need to reorder anything. |
398b845
to
35551b8
Compare
Would it be reasonable to add an option to show the health value directly as a number instead of a color indicator? |
Sweet! |
Currently investigating the failure |
904dfaf
to
a6a2c54
Compare
a6a2c54
to
2ee43eb
Compare
IMHO the column title should be an icon. It's ridiculously wide at the moment. |
I was thinking the same thing, gotta find a good one |
Made several changes:
|
2ee43eb
to
aa2690c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things that need fixing.
Also, the new column is shown by default when you have a local keepassxc.ini and it is hidden when you don't. The default for whether this column is shown or hidden should be set explicitly. There may also be other columns which are missing an explicit default, which should be fixed along with it. I also believe the "Modified" column should be hidden by default.
aa2690c
to
d187cad
Compare
Changes made, ready for final |
* Closes keepassxreboot#4216 Reduced to three-tiered rating system and fixed column implementation. Hide password strength indicator in entry view if excluded from reports. Introduce password health caching to prevent unnecessary calculations.
d187cad
to
7149821
Compare
Uses password health checker in order to retrieve password strength and color futher explained via tool-tip when hovering over column. Hidden by default
Closes #4216
Screenshots
Testing strategy
Unit and manual testing
Type of change