Browser service search for entries by UUID #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this way a lot more! We can extend this method to other attributes in the future. |
|
This has one drawback in the UI though: The allow confirmation dialog now says |
piegamesde
force-pushed
the
uuid-matching
branch
11 times, most recently
from
805f8c7 to
2aea58a
Compare
droidmonkey
changed the title
droidmonkey
force-pushed
the
uuid-matching
branch
from
1d22018 to
423946a
Compare
droidmonkey
approved these changes
Sep 1, 2020
|
@varjolintu if you are good with this we can merge it. |
varjolintu
approved these changes
Sep 1, 2020
phoerious
added
pr: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my second take on implementing keepassxreboot/keepassxc-browser#533 .
The idea is to add custom handling for URLs that start with
keepassxc://. If a search URL matcheskeepassxc://by-uuid/<uuid>and an entry with that UUID exists, it will be returned.This concept could be extended to search for entries using other attributes or more complex search queries, but I don't plan on doing that.
Testing strategy
Successful dogfooding for multiple months (:
Type of change