Add a -n (--notes) option to keepassxc-cli add and edit commands

[grimkor]

Was working on exporting my data from Bitwarden where I use notes to KeePass and noticed the keepassxc-cli was missing notes as an option for adding and editing records. Looked easy enough to plug in so figured I would give it a go. Hopefully it is to taste!

Screenshots

Testing strategy

Manual testing performed with existing and newly created databases through the develop branch version. Changes show to be reflected correctly in the databases.

Type of change

• ✅ New feature (change that adds functionality)

[droidmonkey]

Technically you can do this by specifying an attribute of name "Notes" from the command line. I do like the shortcut though!

[grimkor]

Technically you can do this by specifying an attribute of name "Notes" from the command line. I do like the shortcut though!

Oh no! Did I do this as a result of failing to read the manual properly?

[louib]

@droidmonkey @grimkor I feel like it makes sense to have a standalone option for that, since the notes are part of the primary attributes set.

Since the notes are a multilines text field, should we split the value on \n?

Also, some new unit tests for the option would be nice :)

[droidmonkey]

Possibly? It's certainly not intuitive unless you know how kdbx works.

[copra7070]

Thanks

[grimkor]

@droidmonkey @grimkor I feel like it makes sense to have a standalone option for that, since the notes are part of the primary attributes set.

Since the notes are a multilines text field, should we split the value on \n?

Also, some new unit tests for the option would be nice :)

Sure I can take a look at splitting the values based on \n c++ is a bit new to me so it might take longer than a more seasoned person.

With regards to the attributes that @droidmonkey mentioned I went back to take a look at the add & edit but couldn't see where you can specify additional attributes in those.

[droidmonkey]

You're right, we also need a way to add arbitrary attributes to entries.

[copra7070]

Thanks

[grimkor]

I'll be honest guys I'm way out of my depth here. There was a merge conflict and I thought I had it but I don't. The errors I can see from TeamCity are outside of my scope of comfort and I don't really want to keep making changes without understanding the language and the project.

Not sure what you would want done here but I am happy to assist where possible.

[louib]

@grimkor @droidmonkey I feel like this one is almost ready to merge. We'd just have to make sure it's correctly rebased with develop and validate that the line breaks behavior is what we want. Currently we need escaping when setting the notes (i.e. -n "testing\\nline breaks")

[droidmonkey]

Agree

[droidmonkey]

Rebased and ready for merge. I cleaned up the code a bit too.