Fix memory leaks (mostly) in tests

[c4rlo]

This makes the tests run successfully with asan (AddressSanitizer).

Type of change

• ✅ Bug fix (non-breaking change which fixes an issue)

Description and Context

The GUI tests still have a bunch of leaks, some from library code, and
some that look real but which I didn't manage to figure out so far.

Screenshots

N/A

Testing strategy

cmake --DWITH_DEV_BUILD=ON -DWITH_ASAN=ON -DWITH_GUI_TESTS=ON -DCMAKE_BUILD_TYPE=Debug .. &&
cmake --build . &&
ctest --output-on-failure

Checklist:

• ✅ I have read the CONTRIBUTING document. [REQUIRED]
• ✅ My code follows the code style of this project. [REQUIRED]
• ✅ All new and existing tests passed. [REQUIRED]
• ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

[phoerious]

Thanks. We generally run tests with leak check on exit disabled, because there are also plenty of leaks in third-party libs.

[phoerious]

Please rebase to release/2.5.2.

[c4rlo]

Thanks. We generally run tests with leak check on exit disabled, because there are also plenty of leaks in third-party libs.

After this change, the only tests that still have leaks reported are testcli, testgui, testguipixmaps. Perhaps we could enable asan in CI for all the others at this point?

[phoerious]

ASAN is already enabled for everything.

[c4rlo]

ASAN is already enabled for everything.

Enabled perhaps, but it seems a failure doesn't block PR merges. Which I'm saying it should (excluding test{cli,gui,guipixmaps}).

[phoerious]

We disabled leak checks on exit, because it's a useless test that fails as soon as some external library doesn't free all its memory before the application terminates. Real leaks that happen during runtime are reported and block PR merges.

Changes were made