Show UI warning for invalid URL's #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
requested review from
droidmonkey and
phoerious
and removed request for
droidmonkey
varjolintu
force-pushed
the
hotfix/browser_url_ui_validation
branch
from
9ac0815 to
b2723ec
Compare
|
Are we going to extend this to the multi url list or wait for 2.6.0? |
|
@droidmonkey I'll test it today and see if it's possible to do. Should be a small fix. |
|
@droidmonkey It was possible. Although only the background color changes after editing. QModelIndex has its limits. |
ba32107
reviewed
Nov 22, 2019
|
You can show an icon in the QModelIndex, that is how I show the paperclip on the entry view model. |
|
@droidmonkey Oh. Didn't know that. I'll add the icon. |
|
Added the icon to the additional URL field's right side + removed the obsolete code from URLEdit class. Thanks for the feedback everyone! |
droidmonkey
approved these changes
Nov 23, 2019
varjolintu
force-pushed
the
hotfix/browser_url_ui_validation
branch
2 times, most recently
from
faaca1b to
47d5cd5
Compare
|
Removed the extra check, now tests with Linux are also fine. Everything's ready if there's nothing more to add. |
varjolintu
force-pushed
the
hotfix/browser_url_ui_validation
branch
from
47d5cd5 to
361dd56
Compare
droidmonkey
force-pushed
the
hotfix/browser_url_ui_validation
branch
from
361dd56 to
5a630cb
Compare
droidmonkey
added a commit
that referenced
this pull request
Jan 4, 2020
Added - Browser: Show UI warning when entering invalid URLs [#3912] - Browser: Option to use an entry only for HTTP auth [#3927] Changed - Disable the user interface when merging or saving the database [#3991] - Ability to hide protected attribute after reveal [#3877] - Remove mention of "snaps" in Windows and macOS [#3879] - CLI: Merge parameter for source database key file (--key-file-from) [#3961] - Improve GUI tests reliability on Hi-DPI displays [#4075] - Disable deprecation warnings to allow building with Qt 5.14+ [#4075] - OPVault: Use 'otp' attribute for TOTP field imports [#4075] Fixed - Fix crashes when saving a database to cloud storage [#3991] - Fix crash when pressing enter twice while opening database [#3885] - Fix handling of HTML when displayed in the entry preview panel [#3910] - Fix start minimized to tray on Linux [#3899] - Fix Auto Open with key file only databases [#4075] - Fix escape key closing the standalone password generator [#3892] - macOS: Fix monospace font usage in password field and notes [#4075] - macOS: Fix building on macOS 10.9 to 10.11 [#3946] - Fix TOTP setup dialog not closing on database lock [#4075] - Browser: Fix condition where additional URLs are ignored [#4033] - Browser: Fix subdomain matching to return only relevant site entries [#3854] - Secret Service: Fix multiple crashes and incompatibilities [#3871, #4009, #4074] - Secret Service: Fix searching of entries [#4008, #4036] - Secret Service: Fix behavior when exposed group is recycled [#3914] - CLI: Release the database instance before exiting interactive mode [#3889] - Fix (most) memory leaks in tests [#3922]
phoerious
added
pr: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description and Context
Shows a warning when editing entry if the URL field has an invalid value.
Also works with Additional URL's page, although the background color only changes after editing.
Screenshots
Valid URL:
Invalid URL:
Invalid URL in Additional URL's page:
Testing strategy
Tests added to
TestBrowserclass.Checklist:
-DWITH_ASAN=ON. [REQUIRED]