Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start minimized to tray for unix... #3899

Merged
merged 2 commits into from
Nov 23, 2019
Merged

Fix start minimized to tray for unix... #3899

merged 2 commits into from
Nov 23, 2019

Conversation

intika
Copy link

@intika intika commented Nov 19, 2019

Type of change

  • ✅ Bug fix (non-breaking change which fixes an issue)

Description and Context

This permit to start the application minimized to system tray
If the system tray is disabled the application will start minimized to the taskbar

Fixes #3171

Related:

Current Behavior

Keepassxc is started minimized to taskbar

New Behavior

Keepassxc will start to system tray
If system tray is disabled Keepassxc start minimized

Testing strategy

mainWindow.hideWindow(); already check if system tray setting is enabled before hiding the window otherwise the window is minimized.

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@droidmonkey droidmonkey added this to the v2.5.2 milestone Nov 23, 2019
@droidmonkey droidmonkey merged commit 3183624 into keepassxreboot:release/2.5.2 Nov 23, 2019
@droidmonkey
Copy link
Member

This does not fix macOS since that is a completely different issue.

droidmonkey added a commit that referenced this pull request Jan 4, 2020
Added

- Browser: Show UI warning when entering invalid URLs [#3912]
- Browser: Option to use an entry only for HTTP auth [#3927]

Changed

- Disable the user interface when merging or saving the database [#3991]
- Ability to hide protected attribute after reveal [#3877]
- Remove mention of "snaps" in Windows and macOS [#3879]
- CLI: Merge parameter for source database key file (--key-file-from) [#3961]
- Improve GUI tests reliability on Hi-DPI displays [#4075]
- Disable deprecation warnings to allow building with Qt 5.14+ [#4075]
- OPVault: Use 'otp' attribute for TOTP field imports [#4075]

Fixed

- Fix crashes when saving a database to cloud storage [#3991]
- Fix crash when pressing enter twice while opening database [#3885]
- Fix handling of HTML when displayed in the entry preview panel [#3910]
- Fix start minimized to tray on Linux [#3899]
- Fix Auto Open with key file only databases [#4075]
- Fix escape key closing the standalone password generator [#3892]
- macOS: Fix monospace font usage in password field and notes [#4075]
- macOS: Fix building on macOS 10.9 to 10.11 [#3946]
- Fix TOTP setup dialog not closing on database lock [#4075]
- Browser: Fix condition where additional URLs are ignored [#4033]
- Browser: Fix subdomain matching to return only relevant site entries [#3854]
- Secret Service: Fix multiple crashes and incompatibilities [#3871, #4009, #4074]
- Secret Service: Fix searching of entries [#4008, #4036]
- Secret Service: Fix behavior when exposed group is recycled [#3914]
- CLI: Release the database instance before exiting interactive mode [#3889]
- Fix (most) memory leaks in tests [#3922]
@jtxnn678
Copy link

jtxnn678 commented Dec 8, 2022

Minimize window at application startup is also not working on Kubuntu 22.04 (kernel 5.16.0.56).

@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Linux pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants