Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining issues with menu keyboard navigation #3248

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Fix remaining issues with menu keyboard navigation #3248

merged 2 commits into from
Jun 11, 2019

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Jun 9, 2019 •
edited
Loading

Type of change

  • ✅ Bug fix (non-breaking change which fixes an issue)

Description and Context

Testing strategy

Tested manually and with existing unit tests

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • ✅ My change requires a change to the documentation, and I have updated it accordingly.
  • ✅ I have added tests to cover my changes.

@droidmonkey
Fix remaining issues with menu keyboard navigation
3ecd10f 
* Entry menu now locks focus on entry when used from menubar
* When using keyboard navigation to select menubar menus, do not lose focus on selected entry
* Fixes #3246
@droidmonkey droidmonkey added this to the v2.4.3 milestone Jun 9, 2019
@droidmonkey droidmonkey requested a review from phoerious June 9, 2019 13:33
@droidmonkey
Enable all entry keyboard shortcuts while in search
9b1d8df 
* Fixes #3034
* When the search text edit has focus, retain selected entry keyboard shortcuts and button pressing capability
@phoerious phoerious merged commit 6d449ac into release/2.4.3 Jun 11, 2019
@phoerious phoerious deleted the hotfix/context-menu branch June 11, 2019 07:37
phoerious added a commit that referenced this pull request Jun 11, 2019
@phoerious
Release 2.4.3
5d6ef0c 
- Fix library loading issues in the Snap and macOS releases [#3247]
- Fix various keyboard navigation issues [#3248]
- Fix main window toggling regression when clicking the tray icon on KDE [#3258]
- Add documentation for keyboard shortcuts to source code distribution [#3215]
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoerious phoerious phoerious approved these changes

Assignees
No one assigned
Labels
accessibility pr: bugfix Pull request that fixes a bug
Projects
None yet
Milestone
v2.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@droidmonkey @phoerious