Hotfix/#2820 more detailed share messages #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2019 21:05
ShareObserver watches all shares to and considers settings only on checking for changes. This fixes an assertion when an export group signal is received, but export was disabled.
Extended the message for shared groups to indicate deactivate import/export and errors when the share was not correctly configured.
droidmonkey
force-pushed
the
hotfix/2820-more-detailed-share-messages
branch
from
8fce6e1 to
4c93269
Compare
droidmonkey
approved these changes
Apr 8, 2019
droidmonkey
added a commit
that referenced
this pull request
Apr 12, 2019
- Fix database deletion when using unsafe saves to a different file system [#2889] - Fix opening databases with legacy key files that contain '/' [#2872] - Fix opening database files from the command line [#2919] - Fix crash when editing master key [#2836] - Fix multiple issues with apply button behavior [#2947] - Fix issues on application startup (tab order, --pw-stdin, etc.) [#2830] - Fix building without WITH_XC_KEESHARE - Fix reference entry coloring on macOS dark mode [#2984] - Hide window when performing entry auto-type on macOS [#2969] - Improve UX of update checker; reduce checks to every 7 days [#2968] - KeeShare improvements [#2946, #2978, #2824] - Re-enable Ctrl+C to copy password from search box [#2947] - Add KeePassXC-Browser integration for Brave browser [#2933] - SSH Agent: Re-Add keys on database unlock [#2982] - SSH Agent: Only remove keys on app exit if they are removed on lock [#2985] - CLI: Add --no-password option [#2708] - CLI: Improve database extraction to XML [#2698] - CLI: Don't call mandb on build [#2774] - CLI: Add debug info [#2714] - Improve support for Snap theming [#2832] - Add support for building on Haiku OS [#2859] - Ctrl+PgDn now goes to the next tab and Ctrl+PgUp to the previous - Fix compiling on GCC 5 / Xenial [#2990] - Add .gitrev output to tarball for third-party builds [#2970] - Add WITH_XC_UPDATECHECK compile flag to toggle the update checker [#2968]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced more detailed messages to show when a specific group cannot be shared (configuration error or disabled in settings).
Small change in
ShareObserverwhich could cause an assertion in development mode and a warning in release mode when sharing export was disabled.Type of change
Description and Context
Introduced detailed messages for sharing label. Since the error messages in the settings are created in a hierarchical fashion, I would refrain from showing when import/export was disabled as long as the settings themselves are invalid.
Found a small issue during debugging. The
ShareObserverdid filter out export shares when the export feature was disabled, but did try to find the export group. This led to warnings/assertions. Since the class does additional filtering of unneeded imports when reacting to the file change signal, I removed the filter of references for group - share associations."Fixes #2820"
Screenshots
Testing strategy
Manually tested.
Checklist: