Snap: improve cursor theme #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given the theming drawbacks on unsupported distros, I do not see the benefit just to correct a mouse cursor. I am going to say NO to this change. |
|
With this change there's no drawback, because the default fusion style is still used. Only forcing the QGTKStyle plugin (which is not done here) creates issues when the GTK2 settings are not exposed by the theme and or DE. So this has only the benefit of using a correct mouse theme when available, if not, nothing changes. Since most users are on Ubuntu, I think this would be a great benefit. |
|
Gotcha |
|
This will be available on the edge channel in about 20 minutes |
droidmonkey
added a commit
that referenced
this pull request
Apr 12, 2019
- Fix database deletion when using unsafe saves to a different file system [#2889] - Fix opening databases with legacy key files that contain '/' [#2872] - Fix opening database files from the command line [#2919] - Fix crash when editing master key [#2836] - Fix multiple issues with apply button behavior [#2947] - Fix issues on application startup (tab order, --pw-stdin, etc.) [#2830] - Fix building without WITH_XC_KEESHARE - Fix reference entry coloring on macOS dark mode [#2984] - Hide window when performing entry auto-type on macOS [#2969] - Improve UX of update checker; reduce checks to every 7 days [#2968] - KeeShare improvements [#2946, #2978, #2824] - Re-enable Ctrl+C to copy password from search box [#2947] - Add KeePassXC-Browser integration for Brave browser [#2933] - SSH Agent: Re-Add keys on database unlock [#2982] - SSH Agent: Only remove keys on app exit if they are removed on lock [#2985] - CLI: Add --no-password option [#2708] - CLI: Improve database extraction to XML [#2698] - CLI: Don't call mandb on build [#2774] - CLI: Add debug info [#2714] - Improve support for Snap theming [#2832] - Add support for building on Haiku OS [#2859] - Ctrl+PgDn now goes to the next tab and Ctrl+PgUp to the previous - Fix compiling on GCC 5 / Xenial [#2990] - Add .gitrev output to tarball for third-party builds [#2970] - Add WITH_XC_UPDATECHECK compile flag to toggle the update checker [#2968]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One issue with Qt snaps is the default cursor theme, which is a fallback theme and quite ugly. I propose the following changes to the snapcraft.yaml file to use the system cursor theme when available. Please see the following thread on the snapcraft forum for more background info and limitations of this: https://forum.snapcraft.io/t/qt-apps-and-gtk-themes-an-investigation-with-partial-success/10513
Type of change
Description and Context
To use the system cursor theme, the snap needs to connect to the appropriate plug (icon theme plug). In addition, a new stage package is required (qt5 style plugins).
Please see screenshots below for the result.
Screenshots
Before:
After:
Testing strategy
Tested on a few different distros. Please see the forum thread above for details.
It works for example with Ubuntu and elementaryOS. Distros that don't support this will keep using the fallback cursor theme, so for them nothing changes, it has only advantages.
Checklist: