Final PR for 2.4.0 #2802
Merged
Final PR for 2.4.0 #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
force-pushed
the
fix/last-chance
branch
from
0d7060d to
7173af9
Compare
|
I cannot get the proxy to communicate with the snap version even after the helper script. I can see from |
|
I have a fix for it, going to push in a moment |
|
And btw, I wonder if that script is even necessary because we changed the native messaging script updating to be enabled by default. Would it solve the problem automatically? However, for me the option is disabled in the settings when using snaps, and it cannot be changed. |
droidmonkey
force-pushed
the
fix/last-chance
branch
2 times, most recently
from
a603e02 to
4c19510
Compare
* passwords.kdbx -> passwords.old.kdbx * passwords.db -> passwords.old.db * passwords -> passwords.old
* The warning about not having a password is now properly shown (previously it did not let you continue at all) * General cleanup of the master key editing workflow
|
The executable running in the snap cannot write to any "dot-folder" so we cannot inject the json file from the snap. This is the purpose of the script. |
droidmonkey
force-pushed
the
fix/last-chance
branch
from
4c19510 to
0b840d2
Compare
* Updated browser extension settings for snap usage * Support Snap 3.0 Changes * Add missing stage packages * Correct proxy communication with snaps
droidmonkey
force-pushed
the
fix/last-chance
branch
from
0b840d2 to
239462e
Compare
droidmonkey
added a commit
that referenced
this pull request
Mar 19, 2019
- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description and Context
make formatwill be run and merged right after this PR and before the tag is made.Checklist:
-DWITH_ASAN=ON. [REQUIRED]