Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor fixes for 2.4.0 #2667

Merged
merged 8 commits into from
Feb 5, 2019
Merged

Various minor fixes for 2.4.0 #2667

merged 8 commits into from
Feb 5, 2019

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Jan 31, 2019

Type of change

  • ✅ Bug fix (non-breaking change which fixes an issue)

Description and Context

Optimized all icons and tweaked 'make icons' commands

If you remove the key from TOTP setup then it will remove all TOTP settings from the entry's attributes.

Screenshots

image

Testing strategy

Tested using MSI installer manually

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@droidmonkey droidmonkey added this to the v2.4.0 milestone Jan 31, 2019
@droidmonkey droidmonkey requested a review from phoerious January 31, 2019 22:57
@droidmonkey droidmonkey changed the title Various Build Fixes for 2.4.0 Various minor fixes for 2.4.0 Feb 2, 2019
src/totp/totp.cpp Outdated Show resolved Hide resolved
src/format/KdbxXmlReader.cpp Show resolved Hide resolved
share/windows/wix-patch.xml Show resolved Hide resolved
@droidmonkey
Copy link
Member Author

I updated the file icon, reposted screenshot

@varjolintu
Copy link
Member

* Fix #1643, app window properly focuses and hides back to its previous state after unlock from browser extension

This works as expected.

Copy link
Member

@phoerious phoerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps pngcrush the PNGs and minify the SVG sources. Rest looks good.

* Fix #1846, kdbx is registered to KeePassXC with
an icon (locked database icon)
* Fix #2489, OpenSSL and Crypto libraries are packaged
to support https connections
* Fix minor typo in KeeShare (missing "?")
* Eliminated multiple state variables
* Fix #1643, window is brought to front
* otp setting is properly loaded and saved (Fix #2671)
* Removing the key from TOTP Setup clears all TOTP
settings for entry
* Santize TOTP key prior to storing in OTP format
* Fix #2251 and Fix #2674
* Icons stored with duplicate UUID's will be
assigned a new UUID on load. This causes entries
using the duplicate UUID to display the default icon.
* Tweaked share/icons/svg/application-x-keepassxc.svg for better scaling
* Added ico build script for Windows
* Shrank large SVG's using Inkscape 'Optimized SVG'
* Added pngcrush script to 'make icons'
* Ran 'make icons'
@droidmonkey droidmonkey merged commit 877a092 into release/2.4.0 Feb 5, 2019
@droidmonkey droidmonkey deleted the fix/windows-build branch February 5, 2019 21:09
droidmonkey added a commit that referenced this pull request Mar 19, 2019
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants