Show a warning message when native messaging host is not found #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
force-pushed
the
script_warning_message
branch
from
3d11a8e to
db1dce3
Compare
droidmonkey
requested changes
Oct 18, 2018
src/browser/BrowserOptionDialog.cpp
Outdated
| m_ui->scriptWarningWidget->showMessage(tr("<b>Warning:</b> keepassxc-proxy binary is not found!" | ||
| "<br />Please check your install path for the file, or check your custom path." | ||
| "<br />KeePassXC needs keepassxc-proxy to receive messages from KeePassXC-Browser." | ||
| "<br />Path: "), MessageWidget::Warning); |
There was a problem hiding this comment.
Recommended wording:
Warning, the keepassxc-proxy application was not found!
Please check the KeePassXC installation directory or confirm the custom path in advanced options.
Browser integration WILL NOT WORK without the proxy application.
Expected Path: %path%
src/browser/HostInstaller.cpp
Outdated
| * @param browser Selected browser | ||
| * @return bool Script is installed correctly | ||
| */ | ||
| bool HostInstaller::checkIfInstalled(SupportedBrowsers browser) const |
There was a problem hiding this comment.
When you changed this to a const function you fail to build on windows because "registryEntryFound" is not a const function.
varjolintu
force-pushed
the
script_warning_message
branch
from
db1dce3 to
0cf4a21
Compare
phoerious
approved these changes
Oct 20, 2018
droidmonkey
approved these changes
Oct 21, 2018
droidmonkey
added a commit
that referenced
this pull request
Mar 19, 2019
- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If keepassxc-proxy binary (default or custom location) is not found after support for some browser is enabled, a warning message will be shown in the Browser Integration settings tab. The path where keepassxc-proxy is loaded will be shown in the message. Hopefully this makes the troubleshooting easier.
The warning message should be as non-tech as possible, but still informative. Any suggestions are very welcome.
And because the class is quite hard to read, I also added some documentation to the functions.
This PR is still under
Needs Worklabel because I haven't tested this with all platforms.Motivation and context
Adds more information about the native messaging host location during troubleshooting.
How has this been tested?
Manually.
Screenshots (if appropriate):
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]