Fix inconsistent icon sizes #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new paperclip is fugly.
|
|
It's a bit ugly, but it's the clip of the icon theme we use and it works better with dark backgrounds. But I'd be fine with an alternative if it looks consistent and works with dark backgrounds. |
|
I'll play around with the svg of the original, invert and add a border |
|
IMHO the original is a little too "straight" if you know what I mean. It lacks a little realism compared to the rest of our icons. |
phoerious
force-pushed
the
hotfix/inconsistent-icon-sizes
branch
from
170826f to
18bf82b
Compare
|
I adjusted the toolbar to use 22x22 instead of 24x24-sized icons. That way no scaling occurs. I'll leave the 32x32 icons anyway, so HiDPI devices can use them (which I hope they'll do). |
weslly
approved these changes
Mar 4, 2018
droidmonkey
approved these changes
Mar 4, 2018
phoerious
added a commit
that referenced
this pull request
Mar 6, 2018
- Fix unnecessary automatic upgrade to KDBX 4.0 and prevent challenge-response key being stripped [#1568] - Abort saving and show an error message when challenge-response fails [#1659] - Support inner stream protection on all string attributes [#1646] - Fix favicon downloads not finishing on some websites [#1657] - Fix freeze due to invalid STDIN data [#1628] - Correct issue with encrypted RSA SSH keys [#1587] - Fix crash on macOS due to QTBUG-54832 [#1607] - Show error message if ssh-agent communication fails [#1614] - Fix --pw-stdin and filename parameters being ignored [#1608] - Fix Auto-Type syntax check not allowing spaces and special characters [#1626] - Fix reference placeholders in combination with Auto-Type [#1649] - Fix qtbase translations not being loaded [#1611] - Fix startup crash on Windows due to missing SVG libraries [#1662] - Correct database tab order regression [#1610] - Fix GCC 8 compilation error [#1612] - Fix copying of advanced attributes on KDE [#1640] - Fix member initialization of CategoryListWidgetDelegate [#1613] - Fix inconsistent toolbar icon sizes and provide higher-quality icons [#1616] - Improve preview panel geometry [#1609]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
Toolbar icons had inconsistent sizes on macOS (not so noticeable on other platforms).
We had a 32x32 icon for the lock, but only 22x22 for the rest. macOS preferred the larger icons, resulting in inconsistently sized icons.
For this patch, I created 32x32 icons for all toolbar icons (and other icons where we have the SVGs). I also created a new "Copy URL" icon from Oxygen icon primitives, making it look more like the rest.
I hope for 2.4 we'll find a suitable new icon set that is more consistent.
How has this been tested?
Tested visually on macOS (no Retina).
Screenshots (if appropriate):
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]