Don't upgrade to KDBX 4 when CustomData are present only in meta data section #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
force-pushed
the
hotfix/customdata-kdbx4-conversion
branch
2 times, most recently
from
53b2b9b to
f6662f7
Compare
TheZ3ro
approved these changes
Feb 28, 2018
|
I recommended this a while ago 😛 |
droidmonkey
approved these changes
Mar 1, 2018
phoerious
force-pushed
the
hotfix/customdata-kdbx4-conversion
branch
from
f6662f7 to
6a0e890
Compare
|
Update: there is another way more severe bug. When the file format is upgraded implicitly, we lose the challenge-response component of the key (see #1584). |
phoerious
force-pushed
the
hotfix/customdata-kdbx4-conversion
branch
from
6a0e890 to
e8c7e2a
Compare
TheZ3ro
approved these changes
Mar 1, 2018
|
Well, that should have never happened. I'll work on some extra challenge-response tests. Our problem is that we cannot really test the real thing, so we need some mock CR key. |
|
I agree but it's not very simple to test |
phoerious
added a commit
that referenced
this pull request
Mar 6, 2018
- Fix unnecessary automatic upgrade to KDBX 4.0 and prevent challenge-response key being stripped [#1568] - Abort saving and show an error message when challenge-response fails [#1659] - Support inner stream protection on all string attributes [#1646] - Fix favicon downloads not finishing on some websites [#1657] - Fix freeze due to invalid STDIN data [#1628] - Correct issue with encrypted RSA SSH keys [#1587] - Fix crash on macOS due to QTBUG-54832 [#1607] - Show error message if ssh-agent communication fails [#1614] - Fix --pw-stdin and filename parameters being ignored [#1608] - Fix Auto-Type syntax check not allowing spaces and special characters [#1626] - Fix reference placeholders in combination with Auto-Type [#1649] - Fix qtbase translations not being loaded [#1611] - Fix startup crash on Windows due to missing SVG libraries [#1662] - Correct database tab order regression [#1610] - Fix GCC 8 compilation error [#1612] - Fix copying of advanced attributes on KDE [#1640] - Fix member initialization of CategoryListWidgetDelegate [#1613] - Fix inconsistent toolbar icon sizes and provide higher-quality icons [#1616] - Improve preview panel geometry [#1609]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed KeePassXC incorrectly (unnecessarily) upgrading to KDBX 4 if CustomData are available on the meta data section.
Resolves #1563 , #1565 and #1584.
Motivation and context
KDBX 4 upgrade should only be done for CustomData in entries or in the KDBX header, not in database meta data. Although an upgrade in itself is not a bad idea, it shouldn't be done automatically if it's not strictly needed.
I know I fixed this bug before and it must have been re-introduced somewhere along the way.
How has this been tested?
Manually and with updated upgrade tests.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]