Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library paths in AppImage recipe and Dockerfiles #1534

Merged
merged 3 commits into from
Feb 27, 2018

Conversation

phoerious
Copy link
Member

@phoerious phoerious commented Feb 27, 2018

Description

  1. Updates the library paths in our deployment and CI scripts (AppImage recipe and Dockerfiles) and adds libcurl-no-gcrypt as new dependency.
  2. Bundles selected Qt plugins with the AppImage and Windows build (i.e., imageformats and platforminputcontexts), resolves Suddenly unable to use ico images #1195 and appimage incompatible with ibus/mozc #1439

Motivation and context

I updated the PPA packages to install into a common root under /opt/keepassxc-libs instead of each having an individual root under /opt. This makes everything more manageable, requires less custom build paths and keeps /opt cleaner. I also added a new (OpenSSL-flavoured) libcurl-no-gcrypt package to the Trusty PPA, because all three libcurl4-* flavours from the Ubuntu repo directly or indirectly pull in libgcrypt11, which conflicts with libgcrypt20 when linked into the same binary (yes, even libcurl4-nss-dev, which is really stupid). Xenial does not have this problem.

Also to ensure both AppImage and Windows deployments can read icons in ICO format (and a few other important formats), I bundled the necessary plugins.
I also bundled platforminputcontext plugins to support alternative input methods, such as ibus on Linux or the screen keyboard on Windows.

How has this been tested?

Packages compile and HTTPS-Requests with the new cURL lib work.

I haven't tested if ibus really works.

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@phoerious phoerious added this to the v2.3.0 milestone Feb 27, 2018
@phoerious phoerious requested a review from a team February 27, 2018 00:53
@phoerious phoerious force-pushed the hotfix/update-deployment branch from 1bba3a7 to 7463ee2 Compare February 27, 2018 01:58
Copy link
Member

@droidmonkey droidmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@droidmonkey droidmonkey merged commit 114f87c into release/2.3.0 Feb 27, 2018
@droidmonkey droidmonkey deleted the hotfix/update-deployment branch February 27, 2018 03:53
phoerious added a commit that referenced this pull request Feb 27, 2018
- Add support for KDBX 4.0, Argon2 and ChaCha20 [#148, #1179, #1230, #1494]
- Add SSH Agent feature [#1098, #1450, #1463]
- Add preview panel with details of the selected entry [#879, #1338]
- Add more and configurable columns to entry table and allow copying of values by double click [#1305]
- Add KeePassXC-Browser API as a replacement for KeePassHTTP [#608]
- Deprecate KeePassHTTP [#1392]
- Add support for Steam one-time passwords [#1206]
- Add support for multiple Auto-Type sequences for a single entry [#1390]
- Adjust YubiKey HMAC-SHA1 challenge-response key generation for KDBX 4.0 [#1060]
- Replace qHttp with cURL for website icon downloads [#1460]
- Remove lock file [#1231]
- Add option to create backup file before saving [#1385]
- Ask to save a generated password before closing the entry password generator [#1499]
- Resolve placeholders recursively [#1078]
- Add Auto-Type button to the toolbar [#1056]
- Improve window focus handling for Auto-Type dialogs [#1204, #1490]
- Auto-Type dialog and password generator can now be exited with ESC [#1252, #1412]
- Add optional dark tray icon [#1154]
- Add new "Unsafe saving" option to work around saving problems with file sync services [#1385]
- Add IBus support to AppImage and additional image formats to Windows builds [#1534, #1537]
- Add diceware password generator to CLI [#1406]
- Add --key-file option to CLI [#816, #824]
- Add DBus interface for opening and closing KeePassXC databases [#283]
- Add KDBX compression options to database settings [#1419]
- Discourage use of old fixed-length key files in favor of arbitrary files [#1326, #1327]
- Correct reference resolution in entry fields [#1486]
- Fix window state and recent databases not being remembered on exit [#1453]
- Correct history item generation when configuring TOTP for an entry [#1446]
- Correct multiple TOTP bugs [#1414]
- Automatic saving after every change is now a default [#279]
- Allow creation of new entries during search [#1398]
- Correct menu issues on macOS [#1335]
- Allow compilation on OpenBSD [#1328]
- Improve entry attachments view [#1139, #1298]
- Fix auto lock for Gnome and Xfce [#910, #1249]
- Don't remember key files in file dialogs when the setting is disabled [#1188]
- Improve database merging and conflict resolution [#807, #1165]
- Fix macOS pasteboard issues [#1202]
- Improve startup times on some platforms [#1205]
- Hide the notes field by default [#1124]
- Toggle main window by clicking tray icon with the middle mouse button [#992]
- Fix custom icons not copied over when databases are merged [#1008]
- Allow use of DEL key to delete entries [#914]
- Correct intermittent crash due to stale history items [#1527]
- Sanitize newline characters in title, username and URL fields [#1502]
- Reopen previously opened databases in correct order [#774]
- Use system's zxcvbn library if available [#701]
- Implement various i18n improvements [#690, #875, #1436]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants